Problem/Motivation

tim-e offered to help with maintaining contact module but has since changed jobs where there isn't the ability to help with this.
jibran has offered to help going forward.
andypost has also expressed an interest - potentially add him too if he is still willing.

Proposed resolution

Swap them in maintainers.txt

Remaining tasks

Patch
Review
Comments

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#10 interdiff-9-10.txt484 bytesnaveenvalecha
#10 contact-maintatiners-2513692-10.patch541 bytesnaveenvalecha
#9 contact-maintatiners-2513692-9.patch545 bytesandypost
#8 contact-maintatiners-2513692-8.patch480 bytespameeela
#5 contact-maintainers-2513692-5.patch480 bytespameeela
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim-e’s picture

tim-e CreditAttribution: tim-e commented

+1. Although I would like to continue on, in reality I don't have the time to do so.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented

+1 to the idea. I have also helped with https://www.drupal.org/project/contact_storage in contrib as well.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan as a volunteer commented

Thanks Tim - if things change - still happy to help

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Parent issue: » #1854480: Remove inactive maintainers from MAINTAINERS.txt

Thanks @tim-e.

pameeela’s picture

pameeela CreditAttribution: pameeela commented
FileSize
contact-maintainers-2513692-5.patch480 bytes
kattekrab’s picture

kattekrab CreditAttribution: kattekrab at Creative Contingencies commented
Status: Active » Needs review 
+++ b/core/MAINTAINERS.txt
-- Tim Eisenhuth 'tim-e' https://www.drupal.org/user/1439114
+- Jibran Ijaz 'jibran' https://www.drupal.org/user/1198144

straightforward 1 line patch.

I'd RTBC - but perhaps we should wait to hear from @andypost first?

Status: Needs review » Needs work

The last submitted patch, 5: contact-maintainers-2513692-5.patch, failed testing.

pameeela’s picture

pameeela CreditAttribution: pameeela commented
Status: Needs work » Needs review
FileSize
contact-maintatiners-2513692-8.patch480 bytes

OK so I didn't pull before I did the patch :) Who knew there were so many changes to maintainers.txt!

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost at Skilld commented
FileSize
contact-maintatiners-2513692-9.patch545 bytes

+1 on mention me as maintainer because I'm anyway on it ;)

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at QED42 commented
FileSize
contact-maintatiners-2513692-10.patch541 bytes
interdiff-9-10.txt484 bytes

small nitpick.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs review » Reviewed & tested by the community

That's great @andypost.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Title: Consider removing tim-e from Maintainers.txt for contact module in favour of jibran and possibly andypost » Remove tim-e from Maintainers.txt for contact module in favour of jibran and possibly andypost
Status: Reviewed & tested by the community » Needs review
Issue tags: +Project governance

Thanks @jibran and @andypost for volunteering for this! Can you both add some links to your work on the module up to now, and also confirm that you can commit to the responsibilities described in http://cgit.drupalcode.org/governance/plain/drupal-core.html for subsystem maintainers?

Once we have that, we can re-RTBC this and assign it to Dries. Both @andypost and @jibran have done great ongoing work in Drupal 8 overall.

Also thanks @tim-e for your previous contributions.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost at Skilld commented

@xjm suppose better to grep commits with 

$ git log core/modules/contact |grep andypost|wc -l
33
$ git log core/modules/contact |grep jibran|wc -l
17
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented

@xjm and these are my and andypost's contributions to the issue queue of contact module.

As a maintainer of shortcut module I'm aware of these responsibilities and yes I can commit to those. @andypost is also the maintainer of comment and history module and by looking at his work in the contact module issue queue I think he is aware of it and has been doing this for a while.

kattekrab’s picture

kattekrab CreditAttribution: kattekrab at Creative Contingencies commented
Status: Needs review » Reviewed & tested by the community

Nice. RTBC!

\o/

kattekrab’s picture

kattekrab CreditAttribution: kattekrab at Creative Contingencies commented
Title: Remove tim-e from Maintainers.txt for contact module in favour of jibran and possibly andypost » Remove tim-e from Maintainers.txt for contact module. Add jibran and andypost
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Assigned: Unassigned » Dries

Thanks @jibran and @andypost!

(Note that the links in #14 are not actually contributions to the module, just issues that are followed. E.g. #2362519: Remove dead code from contact.install is listed but has no comments from either of our new maintainers. :) Which is why I meant to suggest linking a couple specific issues since d.o no longer supports a view for it. But @andypost's grep shows it clearly.)

Assigning to Dries for review. Thanks for adopting another module.

Dries’s picture

Dries CreditAttribution: Dries commented
Assigned: Dries » Unassigned
Status: Reviewed & tested by the community » Fixed

This looks great to me! Thank you tim-e, jibran and andypost.

  • Dries committed 317aae5 on 8.0.x 
    Issue #2513692 by pameeela, naveenvalecha, andypost: Remove tim-e from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.