Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
There are two ways a views handler can provide form elements:
1) The viewsForm method (what everyone uses)
2) Setting $this->views_form_callback to a function, which is then called
#2 was added for editablefields in the initial views form patch back in 2011, since then completely unused. Also undocumented, and with 0 tests.
Let's quietly remove it.
The disruption from this change is 0.
Steps to reproduce
Proposed resolution
Remove references to views_form_callback.
Remaining tasks
User interface changes
API changes
views_form_callback is no longer supported.
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2560447-1-remove-views-form-callback.patch | 1.39 KB | bojanz |
Comments
Comment #2
bojanz CreditAttribution: bojanz at Centarro commentedComment #3
dawehnerLet's drop it, if we really don't need it any longer. Great!
Comment #4
jibran+1 to #3. Let's do this.
Comment #13
longwaveJust rediscovered this. This isn't used in core or contrib, so hopefully we can silently drop this without a formal deprecation? http://grep.xnddx.ru/search?text=views_form_callback&filename=
Added a change record just in case: https://www.drupal.org/node/3222564
Amazingly the patch still applies!
Comment #15
catchI think this one is OK to take out given complete lack of usages, documentation, or tests.
Committed 3fb0ede and pushed to 9.3.x. Thanks!