In the Edit personalization What page, if you add a variation set, and it has 5 or more custom block, it overflows, because a maximum height is 200rem. We should increase this height. We should not remove this attribute because CSS animations can't work without a fixed or a maximum height.

Follow up: https://www.drupal.org/commitlog/commit/63789/bb321b278eea5d2bf26a4c37f4...

CommentFileSizeAuthor
#2 edit_issue_fixed-2561583-1.patch406 bytestompagabor
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tompagabor created an issue. See original summary.

tompagabor’s picture

tompagabor CreditAttribution: tompagabor at Cheppers commented
FileSize
edit_issue_fixed-2561583-1.patch406 bytes
tompagabor’s picture

tompagabor CreditAttribution: tompagabor at Cheppers commented

On the other hand we could remove totally this code, because the animation isn't working currently. I couldn't find anything what triggered this animation.

tompagabor’s picture

tompagabor CreditAttribution: tompagabor at Cheppers commented
Status: Active » Needs review
ynx’s picture

ynx CreditAttribution: ynx commented

Fix works great. Merged.

P.S. The animation is used when you click on the "el-card__header", I think.

  • tompagabor authored da2cd5b on 7.x-2.x 
    Issue #2561583 by tompagabor: LCS-102 Fixed heights on variation block...
ynx’s picture

ynx CreditAttribution: ynx commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.