Problem/Motivation
Extending config translation is hard without having access to the entity itself.
Proposed resolution
Expose the entity through a getter.
Remaining tasks
Discuss if acceptable,
Patch,
Reviews
User interface changes
None.
API changes
API addition. getEntity in ConfigEntityMapper.
Data model changes
None.
Beta phase evaluation
Issue category | Task |
---|---|
Issue priority | Major because is blocking other usability bugs like #2546212: Entity view/form mode formatter/widget settings have no translation UI |
Prioritized changes | The main goal of this issue is usability for other issues by adding just new getter for ConfigEntityMapper |
Comment | File | Size | Author |
---|---|---|---|
#4 | 2565031-configentitymapper-4.patch | 2.13 KB | penyaskito |
#4 | 2565031-configentitymapper.interdiff.2-4.txt | 2.17 KB | penyaskito |
Comments
Comment #2
penyaskitoImplemented getter + test.
Comment #3
vijaycs85Nice one @penyaskito.
Funny, we have set, but no get.
Needs updated comment.
Also, thinking it's worth renaming the testSetEntity to accommodate get as well? Because most of the code seems common.
Comment #4
penyaskitoYou are right, let's test both in the same test.
Comment #5
vijaycs85Looks good to me.
Comment #8
penyaskitoBack to RTBC, the error was unrelated.
Comment #9
penyaskitoComment #10
penyaskito@alexpott asked for a good beta evaluation if we want this considered for 8.0.0
Comment #11
tstoeckler#2546212: Entity view/form mode formatter/widget settings have no translation UI will probably end up needing this. This is really an oversight, would be great to get this in.
Comment #12
rodrigoaguileraAdded the beta evaluation and raised the priority.
I'm not sure if it can be back to RTBC but let's be bold.
Comment #13
alexpottI'm committing this under the maintainer discretion provision in the beta policy since it will enable contrib and has zero disruption. Committed 068f6ad and pushed to 8.0.x. Thanks!
Comment #15
Gábor HojtsyYay!