Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Hi,
Maybe updating the subscriber list every time cron is run (typically every hour) is a bit too much. Besides, since simplenews is sending emails in several batches at cron time, it is a bit odd to modify the subscriber list while the mail is being sent.
So I suggest we remove the cron hook, and only update the subscription list when a newsletter is created. I am submitting a patch for this. The patch includes a install/update hook to make sure simplenews_roles hooks are run before simplenews ones.
Also in this patch, I added a query to remove users that are not subscribed to any newsletter from the subscription table. You may want to incorporate this even if you decide to keep the cron hook.
Patrick
| Comment | File | Size | Author |
|---|---|---|---|
| simplenews_roles.tar.gz | 1.22 KB | pfournier |
Comments
Comment #1
joachim CreditAttribution: joachim commentedI agree that every cron run is a bit excessive, especially given that the DB updating code is not that clean (it deletes everything and re-inserts all records)
> I added a query to remove users that are not subscribed to any newsletter from the subscription table
I think Simplenews itself does that now.
The question is now: which events should cause synchronization?
I reckon:
- on user change / add / delete
- newsletter creation (ie the taxonomy term)
Do we need:
- newsletter node creation?
Bumping this to D6 -- discussion welcome :)