Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This was found in #2584603: PHP exception on manage fields after enabling Configuration Translation
Problem/Motivation
In WebTestBase::setUp()
$this->installParameters()
is called and the parameters are then passed into $this->doInstall()
. That method does document a $parameters
variable but it never actually uses it but instead calls $this->installParameters()
itself.
Proposed resolution
Remove the unneeded argument and superfluous method call.
This is 100% backwards compatible and only changes test code so is eligible during the RC.
Remaining tasks
User interface changes
None.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#2 | 2589599-simpletest.patch | 1.19 KB | tstoeckler |
Comments
Comment #2
tstoecklerComment #3
stevector+1 for removing unused code.
Comment #4
dawehnerIts not only that, also tests are not an API so we can change it at any given point.
Nice find @tstoeckler!
Comment #5
tim.plunkettI personally would have removed the second method call and used the parameters, but either way is better than HEAD.
Comment #6
alexpottCommitted 2b92ca2 and pushed to 8.0.x. Thanks!