Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Follow-up to #2584837: Double translation in template_preprocess_field_multiple_value_form()
Remove nested 'title' render array because that's two render arrays that we don't need.
$header = array(
array(
'data' => array(
'#prefix' => '<h4 class="label">',
'title' => array(
'#markup' => $element['#title'],
),
'#suffix' => '</h4>',
),
'colspan' => 2,
'class' => array('field-label'),
),
Proposed resolution
Bring it down to one render array.
Remaining tasks
Ensure this still works through manual testing.
Comment | File | Size | Author |
---|---|---|---|
#2 | 2592025-2.patch | 546 bytes | joelpittet |
#10 | 2016-09-30_08-43-20.png | 62.02 KB | jordana |
#10 | 2016-09-30_08-42-10.png | 73.46 KB | jordana |
Comments
Comment #2
joelpittetComment #3
joelpittetComment #6
joelpittetComment #7
joelpittetComment #8
jordanaI'll take a look at this
Comment #9
aburrows CreditAttribution: aburrows as a volunteer commentednull
Comment #10
jordana@protitude basically mentored me in helping me test this.
We're both first time contributors and are at Drupalcon Dublin
We tested the patch and it works well - no visual change before and after.
Checked rendered markup and all looks good.
Attached screenshots -
Before: 2016-09-30_08-42-10.png
After: 2016-09-30_08-43-20.png
Comment #11
aburrows CreditAttribution: aburrows as a volunteer commented@jordana has shown this to me and there are no differences, screenshots have been taken for consistancy for the issue.
RTBC++
Comment #12
alexpottCommitted 29a02cb and pushed to 8.3.x. Thanks!