Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#7 | Module_override_of_result_set_not_working-2592875-7.patch | 1.65 KB | JordiK |
|
Comments
Comment #2
pedrorocha CreditAttribution: pedrorocha commentedHi @jhedstrom, it wasn't clear what happened to you. Can you give more details?
Comment #3
jhedstromThese are the 2 commented out tests from the patch in #2592867: Get tests passing and enable automated tests for 8.x. The tests are looking for the ability of other modules to change result sets. Rather than try and fix it there, I opened this separate issue.
Comment #4
pedrorocha CreditAttribution: pedrorocha commentedOk. I'll keep it open for now, as no one is using it yet and we have many things to do to have the basic features working. BTW, if you have more ideas of tests to do, please let me know or send a patch. I just created the basic stuff there to start the port, but it's good to map more tests to have a good code coverage.
Comment #5
pedrorocha CreditAttribution: pedrorocha commentedI'm working on Fivestar port to D8(currently on https://github.com/pedrorocha-net/fivestar) and this problem arose for me too. I'm going to work on it soon.
Comment #6
TR CreditAttribution: TR commentedI had to look through all the test source code to find this - it wasn't described in the issue you linked to. There should really be a @see after the @todo in the test so that in case anyone wants to work on this they can find it.
This patch just adds the @see, it doesn't fix the test.
Comment #7
JordiK CreditAttribution: JordiK commentedSmall things are hard to spot.
The two lines, which failed the tests are checking whether the custom result function plugin Zebra is registered.
The problem was misspelled plugin annotation in votingapi\tests\modules\votingapi_test\src\Plugin\VoteResultFunction\Zebra.php
It read @VoteResult, but should have been named @VoteResultFunction instead.
I removed the comments of both asserts in question - now the test runs without errors.
Comment #8
TR CreditAttribution: TR commentedWOW. Really nice work @JordiK. That has been wrong for 5 years and no one spotted it!
Comment #10
pifagorgood catch )