Breadcrumb is displayed on the front page, when visiting in a different language (e.g. /fr)

Hm, nothing specific in SystemBreadcrumbBlock about visibility. Not sure where it is specified.

I guess the problem is that \Drupal\system\PathBasedBreadcrumbBuilder::build might return something, even usually it should not for the frontpage.

Tried debugging the \Drupal\system\PathBasedBreadcrumbBuilder::build but could not find anything here. Problem seems to be somewhere else

Guys sorry for the previous comment, the issue was \Drupal\system\PathBasedBreadcrumbBuilder::build where the homepage was not correctly identified. Ive created a patch and attached

Needs tests on its own.

+++ b/core/modules/system/src/PathBasedBreadcrumbBuilder.php
@@ -167,7 +167,8 @@ public function build(RouteMatchInterface $route_match) {
     }
-    if ($path && '/' . $path != $front) {
+    $front_page = \Drupal::service('path.matcher')->isFrontPage();
+    if (!$front_page) {

Do we need to take care about some other bits as well, like

    // Don't show a link to the front-page path.
    $front = $this->config->get('page.front');
    $exclude[$front] = TRUE;

?

It seems to be that there are multiple places where we deal with the frontpage

@dawehner how about removing

    // Don't show a link to the front-page path.
    $front = $this->config->get('page.front');
    $exclude[$front] = TRUE;

and only handling it at one place? I've attached a inter-diff for the same

I would rather suggest something like this

Removing from sprint so it reflects what is currently being worked on.
Unfortunately.

Discussed with @xjm and @catch and manually tested myself. We agreed that this is a major bug because the breadcrumb should not be showing.

We should either just use Url or use the injected Url builder - I went for injection since the patch was going that way anyway.

Tests should pass now.

-    $front = $this->urlGenerator->generateFromRoute('<front>', [], TRUE)->getGeneratedUrl();
+    $front = $this->urlGenerator->generateFromRoute('<front>', [], [], TRUE)->getGeneratedUrl();

So that doesn't work because the front page is '/node' but the url generator makes it '/' which means it doesn't get excluded properly when the literal front page path is there such as node/add/page when '/node' is configured as the front page.

This might do it.

+++ b/core/modules/system/src/PathBasedBreadcrumbBuilder.php
@@ -99,12 +109,13 @@ class PathBasedBreadcrumbBuilder implements BreadcrumbBuilderInterface {
+  public function __construct(RequestContext $context, AccessManagerInterface $access_manager, RequestMatcherInterface $router, InboundPathProcessorInterface $path_processor, ConfigFactoryInterface $config_factory, UrlGeneratorInterface $url_generator, TitleResolverInterface $title_resolver, AccountInterface $current_user, CurrentPathStack $current_path) {

Also, this is really getting silly. Might want a follow-up to revisit it.

I tried the patch and it seems it doesn't work when Drupal is installed in a sub-directory of the webservice web root, because removing front ("/") doesn't completely work. Is there something like the base_path in D7 we can use?

I am hesitant to close this because I can't see where it was fixed, but I can't reproduce this in 9.0.1 and the steps are quite simple so I don't think I'm missing anything.

I tried a few ways, on two different installs, with the default /node home page and with an actual node set as the home page, and with a few languages but I'm not getting a breadcrumb on home in any language.

Home with /node - English (default)

Home with /node - French

Home with /node/1 set to home - Chinese, Traditional (default)

Home with /node/1 set to home - English

I think Closed (outdated) is the right status for this where obviously it was an issue at one time, but so much has changed and it's no longer occurring, but I can't find any likely duplicates.

If anyone can provide updated steps to reproduce the issue (starting from "Install Drupal core"), document those steps in the issue summary and set the issue status back to "Active".

Thanks!

I tested it for the latest commit of the 9.1.x branch, then the 8.8.x branch. Cannot reproduce the original issue, the breadcrumb stays hidden on the homepage.

Steps taken:

• Install Drupal
• Enable the Language and Content Translation modules
• Add a second language
• Visit the home page in both languages, clearing caches between each visit. No breadcrumb.
• Mark the "Article" content type as translatable, as well as the title field
• Create an Article node in the default language
• Translate the node in the second language, changing the title
• Visit the home page in both languages. Still no breadcrumb, as expected.
• Change the home page page to node/{node id} of the newly created Article
• Visit the new home page in both languages, always clearing caches. Still no breadcrumb, as expected.

No idea why it changed the status to Needs Work, was not intentional.

Unassigning this issue as it could not be reproduced.