Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When admin check the "Enable individual comment feeds for each post on the website" would be nice if he can select to which content type it should apply.
Comment | File | Size | Author |
---|---|---|---|
#8 | add_content_type_filter-2601284-8.patch | 2.88 KB | felribeiro |
Comments
Comment #2
felribeiro CreditAttribution: felribeiro at CI&T commentedAdd content type filter.
Comment #3
felribeiro CreditAttribution: felribeiro at CI&T commentedComment #4
larruda CreditAttribution: larruda at CI&T commented@felribeiro thanks for your contribution! I've got 2 things to be done prior to this being accepted:
1) Fix some typos in the following sentence:
"Select the contenty type that will show individual feed icon. If blanck, it will show in all content type."
Perhaps the correct would be:
"Select which content types will present an individual feed icon. If blank, it will show up in all content types."
2) Get someone from the community to review and test this patch (after the fix above) and put the issue as "Reviewed & Tested By The Community".
Please let me know of any updates.
Thanks again!
Comment #5
felribeiro CreditAttribution: felribeiro at CI&T commented@larruda thanks for your review.
Comment #6
luco CreditAttribution: luco as a volunteer and at CI&T commentedworks like a charm. here's an updated version with a slight grammar review.
Comment #7
larruda CreditAttribution: larruda at CI&T commented@luco @felribeiro, I've just tested the patch and indeed it works just as expected, however I still have a suggestion for you guys.
The title of the new select field "Filter individual feeds by content type" gives me the idea that I can enable the RSS for specific content types. That's not really true, because what it really does it show/hide the feed icon from the node's page but the actual hook_menu continues working for all content types. I noticed it's well explained in the helper text right below the field, but it's something that's is likely to be unnoticed for most users.
So I suggest for you guys to either 1) change the title to something near "Show the feed icon to specific content types:" or 2) actually filter the unselected content types from the rss output.
Do you agree??
Comment #8
felribeiro CreditAttribution: felribeiro at CI&T commented@larruda, I agree. In my opinion the first, "Show the feed icon to specific content types:", is the best.
Comment #10
larruda CreditAttribution: larruda at CI&T commentedComment #11
larruda CreditAttribution: larruda at CI&T commented