When admin check the "Enable individual comment feeds for each post on the website" would be nice if he can select to which content type it should apply.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

felribeiro created an issue. See original summary.

felribeiro’s picture

Add content type filter.

felribeiro’s picture

Status: Active » Needs review
larruda’s picture

@felribeiro thanks for your contribution! I've got 2 things to be done prior to this being accepted:

1) Fix some typos in the following sentence:
"Select the contenty type that will show individual feed icon. If blanck, it will show in all content type."
Perhaps the correct would be:
"Select which content types will present an individual feed icon. If blank, it will show up in all content types."

2) Get someone from the community to review and test this patch (after the fix above) and put the issue as "Reviewed & Tested By The Community".

Please let me know of any updates.

Thanks again!

felribeiro’s picture

FileSize
2.81 KB

@larruda thanks for your review.

luco’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
2.88 KB

works like a charm. here's an updated version with a slight grammar review.

larruda’s picture

@luco @felribeiro, I've just tested the patch and indeed it works just as expected, however I still have a suggestion for you guys.

The title of the new select field "Filter individual feeds by content type" gives me the idea that I can enable the RSS for specific content types. That's not really true, because what it really does it show/hide the feed icon from the node's page but the actual hook_menu continues working for all content types. I noticed it's well explained in the helper text right below the field, but it's something that's is likely to be unnoticed for most users.

So I suggest for you guys to either 1) change the title to something near "Show the feed icon to specific content types:" or 2) actually filter the unselected content types from the rss output.

Do you agree??

felribeiro’s picture

@larruda, I agree. In my opinion the first, "Show the feed icon to specific content types:", is the best.

  • larruda committed 30371cd on 7.x-2.x authored by felribeiro
    Issue #2601284 by felribeiro, luco: Possibility to filter the content...
larruda’s picture

larruda’s picture

Assigned: Unassigned » larruda
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.