Problem/Motivation

content_translation_enable() will never run. There is no hook_enable() anymore. See https://www.drupal.org/node/2193013

Proposed resolution

Move to hook_install(). Add tests.

Remaining tasks

Add tests.

User interface changes

Helpful messages will be back.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#9 2632560-9.patch1.71 KBvijaycs85
#3 2632560-3.patch1.53 KBvijaycs85
#3 2632560-test-only-3.patch717 bytesvijaycs85
#2 2632560.patch851 bytesGábor Hojtsy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy created an issue. See original summary.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue summary: View changes
Status: Active » Needs review
Issue tags: +Needs tests
FileSize
2632560.patch851 bytes
vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 at Capgemini commented
Issue tags: -Needs tests
FileSize
2632560-test-only-3.patch717 bytes
2632560-3.patch1.53 KB

Guess just this one line would do.

The last submitted patch, 2: 2632560.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented

For BC reasons we better keep the function, people might call that function in custom code. (Applying the strict BC policy we have in RL)

Status: Needs review » Needs work

The last submitted patch, 3: 2632560-3.patch, failed testing.

The last submitted patch, 3: 2632560-test-only-3.patch, failed testing.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

All right, we can keep the function but I have little faith that anybody may call it. Its true that we better be safe than sorry.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 at Capgemini commented
Status: Needs work » Needs review
FileSize
2632560-9.patch1.71 KB

Thanks @dawehner and @Gábor Hojtsy for the feedback. Here is the updated version of patch.

Status: Needs review » Needs work

The last submitted patch, 9: 2632560-9.patch, failed testing.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

So looks like some tests do not enable the language module properly or do not generate the routes :(

edurenye’s picture

edurenye CreditAttribution: edurenye at MD Systems GmbH commented

Isn't this the same as this older issue #2342015: Content Translation module still implements hook_enable?

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs work » Closed (duplicate)
Issue tags: -sprint

Right, we can move over there. @vijaycs85: can you apply the non-removal of the enable hook there and post an update? Thanks a lot!