Drupal 8 port

Any help are welcome :)

Is there any activity here yet? If not, I'm ready to start work on it - or if there is, to help out.

OK, thanks. I will assign this issue to myself.

Development branch has been created, feel free to provide patch.

Bump this. Any help are welcome :)

Hi together

I created a patch for the 8.x-1.x-dev branch, which does the following:
- Fix some problems with D7 style user/account property access.
- Move the Menu Items to /admin/config/search/shurly
- Fixed the redirect subscriber
- Fixed the schema for the config var shurly_redirect_page from boolean to string
- Fixed basic code style issues

I want to note, that right now i am just using the functions to programatically create short urls, which seems to work right now. Maybe this patch can act as base for a further development.

Cheers

Just moved the shirly_counter settings from config to state, since this counter should be environment specific and not kept synchronised over all environments. Now the config is only used to define the start counter.
Otherwise each generated short url would lead to changed config, which is not what we want i guess.

Any updates on this?

Hello,

Unfortunatly, i have less time to work on this, but i'll be happy to add a maintainer for the D8 port :)

Hello,

In the ShurlySubscriver class, line 28, I got a && !empty($_GET['redirect']) that is preventing any redirection to work on my raw install of Druptal 8.

I was wondering what is its purpose to know if I can remove it or if I should use it.

More globally, do you have a "to do list" of what prevents you to finalize the Drupal 8 port to be the latest stable release available ?

Thanks

@kaamui I also found that !empty($_GET['redirect']) it causing the issue for redirection or URLs.

I tested the patch from #12 and it works very nice. Unfortunately I wasn't able to place the block because of an error in blockAccess method.

What do you think about trying to get this in so we can continue adding features/fixes in other issues?

I noticed that the form looks very ugly so I will create an issue that we can get AJAX behavior for it.

Here are two follow-up issues:

• #3128651: Implement dropbutton for operation links
• #3128662: Refactor shorten URL form

The patch before removed the theme function which was not the plan for this issue.

I still use this module. I will probably put off upgrading my site that uses it as long as possible, but after that I'll try to review this and maybe apply to be a co-maintainer.

Is there an issue for writing a D7-D8 migration? Those of us who are upgrading will likely want one.

I'd like to help get a working version of this module in D8. As yannickoo mentioned, it would be good to commit some of the basic fixes to the dev branch so we can move forward from there with more focused issues. If there are no other volunteers I can help maintain a D8 branch.

I'd also be interested in helping with a D8/9 version.

I have opened the MR to be able to use these changes using composer.
The followings are the steps I followed,

1. Updated composer.json with
   

   "repositories": [
           {
               "type": "composer",
               "url": "https://packages.drupal.org/8",
               "exclude": [
                   "drupal/shurly"
               ]
           },
           {
               "type": "package",
               "package": {
                   "name": "drupal/shurly",
                   "version": "dev-custom",
                   "type": "drupal-module",
                   "source": {
                       "type": "git",
                       "url": "git@git.drupal.org:issue/shurly-2633910.git",
                       "reference": "shurly-2633910"
                   }
               }
           }
       ],
   

2. Then on terminal required the package using: composer require 'drupal/shurly:dev-custom#7a7b1f40e2a80bb30d5f27d8ba743a95a83d493b' The hash id is the latest commit hash of the MR

Marking #19 as RTBC. Sorry @rahul.shinde, but the D9 issue is another one.