Reference to https://www.drupal.org/node/2631656
Status disabled is no more work in Drupal 8.
Change it to uninstalled.

CommentFileSizeAuthor
#13 2637988-13.patch4.47 KBashhishhh
#9 2637988-9.patch3.52 KBfelribeiro
#6 2637988-5.patch3.19 KBfelribeiro
#3 2637988-3.patch2.99 KBfelribeiro
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ashhishhh created an issue. See original summary.

felribeiro’s picture

felribeiro CreditAttribution: felribeiro at CI&T commented
Assigned: Unassigned » felribeiro
felribeiro’s picture

felribeiro CreditAttribution: felribeiro at CI&T commented
Status: Active » Needs review
FileSize
2637988-3.patch2.99 KB

Status: Needs review » Needs work

The last submitted patch, 3: 2637988-3.patch, failed testing.

ashhishhh’s picture

ashhishhh CreditAttribution: ashhishhh at Valuebound commented

Thanks for the patch.

As mentioned on https://www.drupal.org/node/2631656#comment-10687036
Can you try pull code first, later provide the patch.

felribeiro’s picture

felribeiro CreditAttribution: felribeiro at CI&T commented
Status: Needs work » Needs review
FileSize
2637988-5.patch3.19 KB

Status: Needs review » Needs work

The last submitted patch, 6: 2637988-5.patch, failed testing.

ashhishhh’s picture

ashhishhh CreditAttribution: ashhishhh at Valuebound commented 
Ashishs-MBP:features ashish$ git apply -v 2637988-5.patch 
Checking patch modules/contrib/features/modules/features_ui/src/Form/FeaturesExportForm.php...
error: modules/contrib/features/modules/features_ui/src/Form/FeaturesExportForm.php: No such file or directory
Checking patch modules/contrib/features/src/FeaturesManagerInterface.php...
error: modules/contrib/features/src/FeaturesManagerInterface.php: No such file or directory
Checking patch modules/contrib/features/src/FeaturesManager.php...
error: modules/contrib/features/src/FeaturesManager.php: No such file or directory
Checking patch modules/contrib/features/src/Plugin/FeaturesAssignment/FeaturesAssignmentExisting.php...
error: modules/contrib/features/src/Plugin/FeaturesAssignment/FeaturesAssignmentExisting.php: No such file or directory

Your patch is giving wrong paths.

 a/src/FeaturesManager.php b/src/FeaturesManager.php

This is how path should be specified in .patch file.

felribeiro’s picture

felribeiro CreditAttribution: felribeiro at CI&T commented
FileSize
2637988-9.patch3.52 KB

Let's try again with the tip #5

Thank you @ashhishhh

felribeiro’s picture

felribeiro CreditAttribution: felribeiro at CI&T commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: 2637988-9.patch, failed testing.

felribeiro’s picture

felribeiro CreditAttribution: felribeiro at CI&T commented
Assigned: felribeiro » Unassigned
ashhishhh’s picture

ashhishhh CreditAttribution: ashhishhh at Valuebound commented
Assigned: Unassigned » ashhishhh
Status: Needs work » Needs review
FileSize
2637988-13.patch4.47 KB

  • nedjo committed 8ff7541 on 8.x-3.x authored by ashhishhh 
    Issue #2637988 by felribeiro, ashhishhh: Features should be marked as...
nedjo’s picture

nedjo
he/him/his
Primary language English
CreditAttribution: nedjo commented
Status: Needs review » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.