Add form to certain view modes to manage moderation

This form should only have accessible destination states that are different from the current moderation state.

On the Moderation configuration form on the bundle, offer a set of checkboxes to pick which view modes the form should be embedded in.

What about providing an alternative formatter for the moderation_state field which renders the form? Once there, you don't need any kind of special purpose configuration UI.

l undecided about it, as it means you have to get your formatter setup right, too. It's another moving part that can break. I don't know if it's more work to make it appear only for the right people, either.

Seriously, do you really install a workflow module and configure that, but at the same time you are not able to configure formatters and like hiding the author information from pages, which is almost the first thing many people do on their site.

So just a random point that this is horrible: Sorting.

1. +++ b/tests/src/Unit/StateTransitionValidationTest.php
   @@ -16,59 +22,147 @@ use Drupal\workbench_moderation\StateTransitionValidation;
   +    $entity_storage->loadMultiple()->willReturn($states);
   

   Do these prophesied $states not need ->reveal() called on them?

2. +++ b/tests/src/Unit/StateTransitionValidationTest.php
   @@ -90,4 +185,71 @@ class StateTransitionValidationTest extends \PHPUnit_Framework_TestCase {
   +  /**
   

   Whitespace.

1. +++ b/src/EntityOperations.php
   @@ -55,4 +64,44 @@ class EntityOperations {
   +      unset($build['moderation_state']);
   

   It was confusing to me that this output disappeared when the workbench_moderation_control was displayed.

2. +++ b/src/EntityTypeInfo.php
   @@ -178,6 +179,73 @@ class EntityTypeInfo {
   +   *   following keys: entity type, bundle name, context (either 'form' or
   +   *   'display'). The keys are the name of the elements as appearing in the
   

   Any reason to duplicate core docs here? Maybe reference \Drupal\Core\Entity\EntityFieldManagerInterface::getExtraFields() instead?

3. +++ b/src/EntityTypeInfo.php
   --- /dev/null
   +++ b/src/Form/BundleModerationConfigurationForm.php
   

   This whole file is just moved/renamed, right? No changes in here?

4. +++ b/src/Form/EntityModerationForm.php
   @@ -1,30 +1,42 @@
   + * Contains EntityModerationForm.php
   

   Contains class name, please.

5. +++ b/src/Form/EntityModerationForm.php
   @@ -32,151 +44,80 @@ class EntityModerationForm extends EntityForm {
   +      '#value' => $this->t('Set'),
   

   "Set" is unsettlingly short; perhaps "moderate", "apply", or "update"?

6. +++ b/src/ModerationInformationInterface.php
   @@ -18,6 +18,18 @@ use Drupal\Core\Form\FormInterface;
   +  public function loadBundleEntity($bundle_entity_type_id, $bundle_id);
   

   I'm not really sure why this is here. It's a convenience method, but it's only implemented and used once, so...

Are you planning to provide a browser test for the form UI?

Because this is critical functionality for workbench_moderation, I think that it would be sensible to add a simpletest, even one with a limited or incomplete test case, for this form.

Your other changes are good to go, I think.

Lovely.

Too bad, but IMHO this is a local maximum we went into.