Just noticed something wonky that made me a little cross eyed,

In \Drupal\Core\Field\FieldItemListInterface there is a systematic mistake.....

There are many @see tags on methods that are not references to other information they are just useless references to them same method!

Take the magic method \Drupal\Core\Field\FieldItemInterface::__set()

  /**
   * Magic method: Sets a property value of the first field item.
   *
   * @see \Drupal\Core\Field\FieldItemInterface::__set()
   */
  public function __set($property_name, $value);

If anyone can point me at the more complete documentation I would be grateful ... otherwise I think these circular @see tags should be deleted.

CommentFileSizeAuthor
#5 2650212-5.patch1.28 KBfelribeiro
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

martin107 created an issue. See original summary.

dawehner’s picture

Ha, I would imagine that __set() should refer to __get() and __isset() to __unset(). Happy that you managed get out of the infinite loop.

jhodgdon’s picture

Issue tags: +Novice

Thanks! Yes we should fix those.

felribeiro’s picture

Assigned: Unassigned » felribeiro
felribeiro’s picture

Status: Active » Needs review
FileSize
1.28 KB
jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me, thanks!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 8a13b8a and pushed to 8.0.x. Thanks!

  • alexpott committed b8af90d on 8.1.x
    Issue #2650212 by felribeiro: FieldItemListInterface @see tags are...

  • alexpott committed 8a13b8a on
    Issue #2650212 by felribeiro: FieldItemListInterface @see tags are...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.