Problem/Motivation

When dealing generically with language types it is annoying that LanguageInterface::TYPE_URL does not have a name or description. It is not exposed nowhere in core, but we shouldn't force contrib modules that do expose language types in some way to alter in a name and description just because we are lazy.

I personally hit this when making the URL language type configurable (which you can only do by manually editing config). The language negotiation UI then shows:
The URL language detection form with 'language detection' as label
With this patch it shows:
The URL language detection form with 'Url language detection' as label
Note again that this will generally never be shown unless you manually edit configuration.

Proposed resolution

Add a name and description to LanguageInterface::TYPE_URL.

Remaining tasks

Answer #26

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Create a patch Instructions Done
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards Instructions

User interface changes

(New or changed features/functionality in the user interface, modules added or removed, changes to URL paths, changes to user interface text.)

API changes

(API changes/additions that would affect module, install profile, and theme developers, including examples of before/after code if appropriate.)

Data model changes

(Database or configuration data changes that would make stored data on an existing site incompatible with the site's updated codebase, including changes to hook_schema(), configuration schema or keys, or the expected format of stored data, etc.)

CommentFileSizeAuthor
#27 interdiff-25-27.txt800 bytesLOBsTerr
#27 2668548-27.patch1.45 KBLOBsTerr
#25 2668548-25.patch683 byteschaitanyadessai
#23 2668548-afterpatch.png23.1 KBgaurav-mathur
#23 2668548-beforepatch.png14.79 KBgaurav-mathur
#20 2668548-20.patch677 bytessahil.goyal
language-url-type.patch682 byteststoeckler
url-language-detection-after.png44.3 KBtstoeckler
url-language-detection-before.png43.84 KBtstoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler created an issue. See original summary.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented
Issue tags: +D8MI, +language-base

Status: Needs review » Needs work

The last submitted patch, language-url-type.patch, failed testing.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

iMiksu’s picture

iMiksu
Location Finland
CreditAttribution: iMiksu as a volunteer commented
Status: Needs work » Needs review

I can't find the failing test anymore. Triggering tests again.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work
Issue tags: +Novice

Patch or MR doesn't apply anymore
The last patch or MR doesn't apply to the target branch, please reroll the code so that it can be reviewed by the automated testbot.

sahil.goyal’s picture

sahil.goyal CreditAttribution: sahil.goyal as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
FileSize
2668548-20.patch677 bytes

As seen that last patch target not correct as per #19 so updating the patch for the latest version 10.1.x, not sure that reroll or interadiff needs to be created or not as last patch does not targeting to the issue number and in comments as well.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm at Agileana commented
Status: Needs work » Needs review
gaurav-mathur’s picture

gaurav-mathur CreditAttribution: gaurav-mathur at Dotsquares Ltd. commented
Assigned: Unassigned » gaurav-mathur
gaurav-mathur’s picture

gaurav-mathur CreditAttribution: gaurav-mathur at Dotsquares Ltd. commented
Assigned: gaurav-mathur » Unassigned
FileSize
2668548-beforepatch.png14.79 KB
2668548-afterpatch.png23.1 KB

Successfully Applied patch #20 for Drupal 10.1.x version. It is working as expected. Adding screenshots to refer after and before patch.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Category: Task » Feature request
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs tests, +Needs change record

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

Changing to feature request.

The IS mentions

shouldn't force contrib modules that do expose language types in some way to alter in a name and description

Then we should test to make sure this possible.

Will need a change record to announce to others this is possible.

chaitanyadessai’s picture

chaitanyadessai CreditAttribution: chaitanyadessai at Specbee commented
Status: Needs work » Needs review
FileSize
2668548-25.patch683 bytes

Added 'name' and 'description' for LanguageInterface::TYPE_URL

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Issue summary: View changes
Status: Needs review » Needs work

@chaitanyadessai this is the same patch as #20.

Still needs test coverage so not ready for review.

LOBsTerr’s picture

LOBsTerr CreditAttribution: LOBsTerr at European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs work » Needs review
FileSize
2668548-27.patch1.45 KB
interdiff-25-27.txt800 bytes

Ok, let's wrap up this issue. I have added tests, which will check, that all language type have names and descriptions.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work
Issue tags: -Needs tests

Thanks for the tests.

Only thing left is the change record I believe. Or explanation on why it's not needed.

Thanks! Super close I think.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.