Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
It is possible to uninstall language module when there is content in that language.
Related: I also had a weird behavior with config entities, but this might be a problem with config translation which is probably covered by #2595535: Show helpful message (do not fatal!) when configuration files have different source language codes and cannot be translated - although it's only a half solution in the end (but it's a good start to not fatal at least). I'll try to figure out again how I got there with that - in short what I saw after I uninstall language: there were some overrides for 'en'. e.g. for the basic content type, it still had the original description, but the default config entity didn't have it. In the UI, on /node/add, the override was still seen, but not in the edit form which is extremely confusing.
Steps to reproduce
- Install standard core
- Create article one - promote to homepage, make sure it has a body
- Install language module
- Install a second language
- Make that second language the default
- Create article two - promote to homepage, make sure it has a body
- Uninstall the language module
- Try to update article two: this will fail with the message 'The value you selected is not a valid choice.' Updating article one is fine.
- visit the frontpage or detail page of the second node- you will not see the body of the second article - you'd assume you want to see it though. Titles are fine.
run drush cedit system.site and you'll see that default_langcode is still set to whatever default language you've chosen.
Proposed resolution
- prevent switching default language when content is made in another already and language module is still enabled?
- reset default_langcode in system.site and reset all content back when language module is uninstalled ?
Remaining tasks
Decide how to resolve
Patch
Review
Commit
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2688003-2.patch | 2.76 KB | swentel |
Comments
Comment #2
swentel CreditAttribution: swentel commentedHere's a failing test
Comment #5
Gábor HojtsyDoes not sound feasible. Why should you not be able to swap default language in this state?
Does default langcode even matter for this bug or would it apply even if there was a node in another language once language module is disabled? Would be good to clear that up first, if the default langcode change is required for this bug or not in the first place.
Comment #6
swentel CreditAttribution: swentel commentedYeah, 1 is not feasible indeed, was just thinking out load there :)
As for 2: no default langcode update does not matter for this bug, it's the value of the langcode (nl which does no exist anymore as a language) for that node that is not valid.
Comment #7
Gábor HojtsyRight, so we don't do any data updates when you remove Dutch but still have language module enabled although that would have similar effects, no? At least if you don't have the language selector on a content type for example. You would get an invalid language and no way to select something else. It would indeed be great to have an API to tell people if there are things dependent on the language and either not let them remove a language / uninstall language module or offer them to remedy the problem by applying a separate language. But that would need to be an open API so anything associating language with things can react. We don't know nor have control over what associates language to something. Eg. its easy to set up an entity reference field to reference languages.
Comment #21
quietone CreditAttribution: quietone at PreviousNext commentedI tested on Drupal 10.1.x, using the steps in the issue summary. I was able to reproduce the problem.
The proposed resolution needs an update based on #5-#7.
I am setting to Active as it appears that this needs a new approach.