Descriptions containing links break admin menu lists.

How about we change the structure to be something like this https://jsfiddle.net/jvc16mqk/
Have an outer div and make entire div clickable with href of node/add.
Description will have a check, if it contains an anchor tag then put it outside the div and apply required formatting otherwise keep description inside div.

Hmmmm.

I suspect this applies to more than just /node/add (blocks as well?) based on the related issue. Based on a quick look I don't see links in the description being discussed there.

Edit: see these other templates:

• admin-block-content.html.twig
• block-content-add-list.html.twig

This is one way you can fix this.
Only for /node/add.
This is just a test. I might not have followed coding standards.

I can review and take a look at the coding standards.

Steps to Replicate the Issue :

Spin up a sandbox site on SimplyTest.me: http://ply.st/drupal/8.0.x
Install as Standard Drupal 8 profile with default configuration.
Navigate to the Add content type page: admin/structure/types/add
Add a new content type with the following settings:
Name: drupal testing
Description: Test with Link
Navigate to the Add content page: node/add

The given bug /issue is already resolved. Please check the screenshot.

Steps to Replicate the Issue :

Spin up a sandbox site on SimplyTest.me
Install as Standard Drupal 8 profile with default configuration.
Navigate to the Add content type page: admin/structure/types/add
Add a new content type with the following settings:
Name: drupal testing
Description: Test with Link
Navigate to the Add content page: node/add

The given issue is already resolved. Please check the screenshot below.

I can't confirm that the issue is resolved in 8.7.x. Links in the description field are still broken.

The patch #8 applies without errors against 8.7.x and fix the issue.

On applying the patch #8 for Drupal 8.9.x it is getting fail , this needs to be reroll .

Rerolled the patch for 8.9.x

I have re-verified this issue and found that it is working fine without applying the patch for all the themes.

Apology for the last comment , I have re-check the issue by applying the patch #23 on drupal 8.9.x and found that it is working fine as expected. Please find the attachment for the same.

Steps To Test

2. Navigate to the Add content type page: admin/structure/types/add
3. Add a new content type with the following settings:

Name: Test
Description: Test with Link

4. Navigate to the Add content page>click "Add Content" button
5. Observe the link and content

Apllied patch #23 .It works fine.
Adding screenshots
Before patch

After patch

RTBC

Here the Patch no 2688793-8.patch and 2688793-23.patch is not working, please see the attachment.

The 2688793-23 patch is working that was some error i fond in my local, here the attachment as proof.

Patch #23 fails the Custom Commands phase and needs a reroll.

Updated the patch in #23 to fix the custom test errors. Kindly review the following patch and interdiff.

Thank you!

Almost there, 3 more CSS-lint errors left.

Patch #34, seems working fine and apply cleanly. Moving to RTBC +1. Added an after patch screenshot for reference.

patch #34 applied cleanly and working as expected, added screenshot for reference

Right now the patch #34 is failed and the issue is with 9.3.x also, so please re-roll the patch for D9 too.

Am adding the SS from d9 and changing the issue tag to 9.3.x-dev

Hi @anmolgoyal74 i have applied the patch and tested the other pages like /admin/structure, /admin/config and found the styles removed. So am adding new patch please review.

SS after patch #34 - /admin/config

SS after patch #34 - /admin/structure

SS after my fix:

Please check the patch with above mentioned pages too.

The IS proposed resolution doesn't match what the patch is doing -- needs an update.

Hi @joachim here we have anchor tag inside anchor tag.

nested a elements are forbidden in HTML syntax. HTML specifications do not say why; they just emphasize the rule.

please refer the link . That's why i used different method to resolve the issue.

Verified and tested patch #42.
Patch applied successfully and looks good to me.

Testing Steps:
# Goto: admin/structure/types/manage/brand_page
# Mention the Title Name
# Mention the description - Test with <a href=“http://www.google.com”>link</a>
# Save Content type
# Goto: node/add
# Check the created content type with description link.

Expected Results:
# Descriptions containing links should not be break admin menu lists.

Actual Results:
# Descriptions containing links break admin menu lists.

Looks good to me.
Need +1 RTBC

Hi @Indrajith KB thanks for the #42 patch, it's working as expected.

Moved to RTBC

@Sakthivel M, thanks for your interest in this issue. Having a working patch is not usually sufficient to mark an issue RTBC. There are several steps, or core gates that an issue must pass first. For this issue, an Issue Summary update was requested in #43 and that has not yet been complete. Since you have worked on the issue and are familiar with it you could address #43 and update the IS.

Setting back to NW for an issue summary update.

@Abhijith S, @dsagar @Sakthivel M, The screenshots added in #28, #29 and #47 are just after new screenshots in the previous comment and not adding to this issue. Therefor credit has been removed per How is credit granted for Drupal core issues.

I have applied #42 patch
patch working fine and applied successfully

After patch the description field when we add a content looks good and in a proper format

Thanks for the patch
for ref sharing screenshot .....

Hi, tested the bug with version (9.4.x-dev and 9.5.x-dev) and its' still there.
applied the patch 2688793-42.patch link styling in description field working fine, after patch.
screenshot attached.

Attached rerolled patch against 9.5x branch,,
Kindly review patch,,

Rectified the following error.

themes/seven/css/components/admin-list.css
58:1 ✖ Unexpected missing end-of-source newline no-missing-end-of-source-newline

Patch in #55 working fine for me on local 9.5

As per #56 screenshots problem resolved.
so changed to RTBC.

• #42 still applied fine to 9.5, so the reroll in #54 was not necessary. Removing credit

  +++ b/core/themes/seven/templates/node-add-list.html.twig
  @@ -16,7 +16,17 @@
  +    {% set descLink = ('href' in type.description['#markup']) %}
  +      <li class="clearfix">
  +        <a href="{{ type.url }}"><span class="label">{{ type.label }}</span>
  +          {% if not descLink %}
  +            <div class="description">{{ type.description }}</div>
  +          {% endif %}
  +        </a>
  +        {% if descLink  %}
  +          <div class="description description-with-link">{{ type.description }}</div>
  +        {% endif %}
  

  This is clever but adds quite a bit of complexity for a very specific edge case. It would also return positive if the description had the string 'href' in it - whether or not it was a link.

• This issue exposes an accessibility bug. The entire row is a link, but only the title is formatted to look like one. If you use a rotor the link text is extremely long and difficult to follow. The solution to the reported issue (links in descriptions look bad) should also fix the accessibility issue. Only the label should be wrapped in <a>, and the CSS can be updated to fix any visual issues caused by that change.

#59 please review the patch

Before

After:

Applied patch #59. It is working as per expected behavior with existing content type and new content type.
Fot ref attached screenshot.

@pradipmodh13 screenshots were provided in the comment just above yours. Adding additional ones provides no benefit and adds noise to the issue. Pre-emptively removing credit.

@Sakthivel M Without an interdiff it's not clear what the patch you added in #59 does differently. I can see, however, that my feedback in #58 was not addressed in it. The current solution with {% set descLink = ('href' in type.description['#markup']) %} and not something that would get committed to core.

But seeing how Seven is being removed in Drupal 10 and will only exist as a contrib theme, maybe there will be more lenience to accepting these kind of solutions. Who knows.

The Seven theme has been removed from Drupal 10 core. I confirmed that this issue only affects Seven and no other themes included with Drupal core, so I am moving this to the contributed Seven project.