Follow-up to #2702669: Add plural labels to Entity Types in Aggregator module

Problem/Motivation

As it has been introduced in #1850080: Entity type labels lack plurality, cannot generate UI text based on label if plural is needed now we have a way to specify plural label for any entity type. Let's do it for Comment module.

Proposed resolution

Add plural labels to all entity types defined by Comment module. More information can be found in the change record: https://www.drupal.org/node/2689949

Remaining tasks

Write the patch.

User interface changes

Nope.

API changes

Nope.

Data model changes

Nope.

CommentFileSizeAuthor
#5 interdiff-2702707-2-5.txt988 bytesjmikii
#5 2702707-2_2.patch1.34 KBjmikii
#2 2702707-2.patch1.34 KBIuliu Boiculese
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

svjuly created an issue. See original summary.

Iuliu Boiculese’s picture

Iuliu Boiculese CreditAttribution: Iuliu Boiculese at ASSIST Software SRL commented
Status: Active » Needs review
FileSize
2702707-2.patch1.34 KB

Here is a patch for this issue

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Reviewed & tested by the community

Looks good, thanks!

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Reviewed & tested by the community » Needs work

Actually, let's add leading commas, for consistency.

+ *     plural = "@count comments"

should be

+ *     plural = "@count comments",

Same for the other one.

jmikii’s picture

jmikii CreditAttribution: jmikii as a volunteer commented
Status: Needs work » Needs review
FileSize
2702707-2_2.patch1.34 KB
interdiff-2702707-2-5.txt988 bytes

Hi all,
This is my first patch ..
I've added the commas

rteijeiro’s picture

rteijeiro CreditAttribution: rteijeiro at Tieto commented
Status: Needs review » Reviewed & tested by the community
rteijeiro’s picture

rteijeiro CreditAttribution: rteijeiro at Tieto commented
Issue tags: +DCTransylvania

Thanks @jmikii. Tagging as it was made during DrupalCamp Transylvania.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Closed (duplicate)
Related issues: +#2702683: Add plural labels to entity types

Hi DCTransilvania contributors and others -- can you please comment on #2702683: Add plural labels to entity types to receive credit? Splitting up patches per-module is not ideal in most cases, especially for a single, simple change, so let's use a combined patch. Thank you!

rosinegrean’s picture

rosinegrean CreditAttribution: rosinegrean at PitechPlus commented
Issue tags: -DCTransylvania