Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Thanks for this marvelous module. It works suberbly on my config other than I receive a warning when I attempt to use remote url (just after hitting submit):
Warning: Parameter 1 to _filefield_source_remote_parse_header() expected to be a reference, value given in filefield_source_remote_value() (line 147 of /usr/share/nginx/html/drupal/sites/all/modules/filefield_sources/sources/remote.inc).
[update] the image still always successfully transfers. I'm running drupal7.43/php5.6/hhvm3.13/nginx1.8/mariadb/ubuntu14.04.
Comment | File | Size | Author |
---|---|---|---|
#9 | filefield_sources-remove-curl-reference.patch | 636 bytes | quicksketch |
#5 | 2703405-5.patch | 732 bytes | heykarthikwithu |
Comments
Comment #2
pribeh CreditAttribution: pribeh commentedI believe this may be the related php error log.
[error] 13074#0: *292 open() "/usr/share/nginx/html/drupal/file/ajax/field_image/und/form-vS0o7UKbvVd6IKZfr3kx8az5WHZvKUlbEGhSkr8g4js" failed (2: No such file or directory), client: 99.249.126.201, server: domain.com, request: "POST /file/ajax/field_image/und/form-vS0o7UKbvVd6IKZfr3kx8az5WHZvKUlbEGhSkr8g4js HTTP/1.1", host: "domain.com", referrer: "http://domain.com/node/add/article"
Comment #3
pribeh CreditAttribution: pribeh commentedComment #4
pribeh CreditAttribution: pribeh commentedComment #5
heykarthikwithuComment #6
pribeh CreditAttribution: pribeh commented@heykarthikwithu, thanks for writing the patch. I applied patch 2703405-5.patch to remote.inc but the warning still shows up for me but now points to line 149 (curl_exec($ch)).
Warning: Parameter 1 to _filefield_source_remote_parse_header() expected to be a reference, value given in filefield_source_remote_value() (line 149 of /usr/share/nginx/html/drupal/sites/all/modules/filefield_sources/sources/remote.inc)
Comment #7
quicksketchThanks for this report. I think we can easily fix this just by removing the by-reference operator from
_filefield_source_remote_parse_header()
. Starting with PHP 5 all objects are always by reference anyway, this is probably some very legacy leftovers. In addition, we don't even modify the cURL handler anyway, so removing the reference operator won't make any difference.Comment #9
quicksketchCommitted the attached patch to 7.x-1.x.