Problem/Motivation

Sometimes admins need to create a fairly similar form

Proposed resolution

Add a clone tab that allows a form to be cloned

Remaining tasks

All

User interface changes

New form for cloning

API changes

None

Data model changes

None

CommentFileSizeAuthor
#8 2716995-clone-forms.3.patch10.54 KBlarowlan
#8 interdiff.txt1.9 KBlarowlan
#4 2716995-clone-forms.2.patch10.42 KBlarowlan
#4 interdiff.txt500 byteslarowlan
#3 2716995-clone-forms.patch9.94 KBlarowlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Assigned: Unassigned » larowlan
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Assigned: larowlan » Unassigned
Status: Active » Needs review
FileSize
2716995-clone-forms.patch9.94 KB
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
FileSize
interdiff.txt500 bytes
2716995-clone-forms.2.patch10.42 KB

And a tab

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented

Looks good to me, just one question in the clone submit handler.

+++ b/src/Form/ContactFormCloneForm.php
@@ -0,0 +1,146 @@
+              'uuid' => NULL,
...
+      'uuid' => NULL,
...
+        'uuid' => NULL,

When do these get filled in? I'd have thought you'd have a new uuid if you've saved the new $contact_form above?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

#5 correct, they're not filled, will sort

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

Actually, the field config ones are, the form one isn't

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
FileSize
interdiff.txt1.9 KB
2716995-clone-forms.3.patch10.54 KB

Fixes UUID issue with the form

  • larowlan committed 5a94c82 on 8.x-1.x 
    Issue #2716995 by larowlan: Allow cloning of forms - tab
  • larowlan committed 64a8738 on 8.x-1.x
    Issue #2716995 by larowlan: Allow cloning of forms - UUID fix
  • larowlan committed 9eb78a2 on 8.x-1.x
    Issue #2716995 by larowlan: Allow cloning of forms
  • larowlan committed cbe59da on 8.x-1.x
    Issue #2716995 by larowlan: Allow cloning of forms - test coverage
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Needs review » Fixed
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

Why that incorporated into module?
There should be generic solution a-la bundle_copy module or maybe a part of "entity" module

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

bundle_copy isn't getting ported to D8 because it can be done using the config import/export forms in core.
However this isn't something that I'd want exposed to users who're building contact forms (which are those who'd be building webforms on D7).
This gives them a nice UI.

Happy to discuss removing it into a separate module if you feel strongly about it.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran at PreviousNext for University of Technology, Sydney commented

Happy to discuss removing it into a separate module if you feel strongly about it.

I think we can leave it here for now until we'll have a complete solution in entity module.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

I think what you said is exactly why bundle_copy should exist in 8.x :)

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

Filed #2717909: Create 8.x version of module

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

RKopacz’s picture

RKopacz CreditAttribution: RKopacz commented

@larowlan I am looking for an easy way to do in D8 what I was able to do with Bundle Copy: Just export a node bundle and import it into another Drupal site. I'm not sure CMI can accommodate this as easily as Bundle Copy could do it in 7 It seems as though you can only import to a cloned version of the site on which the bundle was created in the first place. Do you know of any documentation on using SMI like Bundle Copy? Because I haven't been able to find it anywhere.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

@RKopacz, see drupal.org/project/entity_clone

RKopacz’s picture

RKopacz CreditAttribution: RKopacz commented

@larowlan I'm surprised that didn't come up in any of my searches. I'll have a look at that.