Fatal error: Nesting level too deep [#2724281]

I tried to export a node with paragraphs and an entity reference to a media entity in the paragraphs. There i got the following error:

PHP Fatal error:  Nesting level too deep - recursive dependency? in /Users/christianfritsch/repositories/thunder/thunder/profiles/thunder/modules/default_content/src/DefaultContentManager.php on line 345
PHP Stack trace:
PHP   1. {main}() /usr/local/bin/drush:0
PHP   2. require() /usr/local/bin/drush:10
PHP   3. drush_startup() phar:///usr/local/bin/drush/drush:114
PHP   4. drush_main() phar:///usr/local/bin/drush/includes/startup.inc:325
PHP   5. Drush\Boot\BaseBoot->bootstrap_and_dispatch() phar:///usr/local/bin/drush/includes/preflight.inc:66
PHP   6. drush_dispatch() phar:///usr/local/bin/drush/lib/Drush/Boot/BaseBoot.php:67
PHP   7. call_user_func_array:{phar:///usr/local/bin/drush/includes/command.inc:185}() phar:///usr/local/bin/drush/includes/command.inc:185
PHP   8. drush_command() phar:///usr/local/bin/drush/includes/command.inc:185
PHP   9. _drush_invoke_hooks() phar:///usr/local/bin/drush/includes/command.inc:217
PHP  10. call_user_func_array:{phar:///usr/local/bin/drush/includes/command.inc:366}() phar:///usr/local/bin/drush/includes/command.inc:366
PHP  11. drush_default_content_export_references() phar:///usr/local/bin/drush/includes/command.inc:366
PHP  12. Drupal\default_content\DefaultContentManager->exportContentWithReferences() /Users/christianfritsch/repositories/thunder/thunder/profiles/thunder/modules/default_content/drush/default_content.drush.inc:85
PHP  13. Drupal\default_content\DefaultContentManager->getEntityReferencesRecursive() /Users/christianfritsch/repositories/thunder/thunder/profiles/thunder/modules/default_content/src/DefaultContentManager.php:266
PHP  14. array_unique() /Users/christianfritsch/repositories/thunder/thunder/profiles/thunder/modules/default_content/src/DefaultContentManager.php:345

Comment	File	Size	Author
#20	2724281-recursion-20.patch	6.58 KB	andypost
#20	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 4 pass
#20	2724281-recursion-test-only.patch	1.93 KB	andypost
#20	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 3 pass, 1 fail
#20	interdiff.txt	4.6 KB	andypost
#15	2724281-15.patch	4.83 KB	andypost
#15	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 4 pass
#15	interdiff.txt	1.2 KB	andypost
#12	2724281-12.patch	4.78 KB	andypost
#12	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 Patch failed to apply
#12	interdiff.txt	2.31 KB	andypost
#8	2724281-7.patch	4.57 KB	andypost
#8	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 Patch failed to apply
#8	interdiff.txt	749 bytes	andypost
#6	2724281-6.patch	4.57 KB	andypost
#6	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 Patch failed to apply PHP 7 & MySQL 5.5, D8.2 Patch failed to apply
#4	nesting_level_too_deep-2724281-4.patch	424 bytes	pguillard
#4	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 4 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

12 May 2016 at 18:07

chr.fritsch created an issue. See original summary.

Comment #2

jwilson3

English

Ecuador

CreditAttribution: jwilson3 at Bluespark commented 10 June 2016 at 22:58

I can confirm this error happens when trying to export paragraphs to code.

* Paragraphs-8.x-1.0-rc5
* Default_content-8.x-1.x-dev

The problem is definitely coming from this line in class DefaultContentManager::getEntityReferencesRecursive()

    return array_unique($entity_dependencies, SORT_REGULAR);

Comment #3

sqndr CreditAttribution: sqndr at Randstad Digital commented 13 June 2016 at 15:01

I just stumbled upon the same issue, when exporting a node (drush dce node 1 --folder=node) that contains multiple paragraph fields.

Comment #4

pguillard CreditAttribution: pguillard commented 18 July 2016 at 08:44

Status:

Active

» Needs review

File	Size
nesting_level_too_deep-2724281-4.patch	424 bytes
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 4 pass

I had the same problem, and found out the same solution.

Comment #5

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 8 August 2016 at 14:38

Status:

Needs review

» Needs work

This is wrong fix
Actual problem here that ContentEntityBase::referencedEntities() does not returns keyed array as the module supposes

Comment #6

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 8 August 2016 at 15:38

Status:

Needs work

» Needs review

File	Size
2724281-6.patch	4.57 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 Patch failed to apply PHP 7 & MySQL 5.5, D8.2 Patch failed to apply

1 file was hidden/shown/deleted

File	Size
nesting_level_too_deep-2724281-4.patch	424 bytes
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 4 pass

Patch fixes the recursion by indexing entities by type:ID

Also it changes protected method in BC way

PS: formattable changes could be separate but check for interface should be there to prevent php errors about passing other then ContentEntityInterface

Comment #7

8 August 2016 at 15:40

Status:

Needs review

» Needs work

The last submitted patch, 6: 2724281-6.patch, failed testing.

File	Size
interdiff.txt	749 bytes
2724281-7.patch	4.57 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 Patch failed to apply

Comment #9

8 August 2016 at 15:50

Status:

Needs review

» Needs work

The last submitted patch, 8: 2724281-7.patch, failed testing.

Comment #10

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 8 August 2016 at 15:57

Status:

Needs work

» Needs review

3 files were hidden/shown/deleted

File	Size
2724281-6.patch	4.57 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 Patch failed to apply PHP 7 & MySQL 5.5, D8.2 Patch failed to apply
interdiff.txt	749 bytes
2724281-7.patch	4.57 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 Patch failed to apply

Something weird with bot and last patch is wrong

Comment #11

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 8 August 2016 at 15:59

Looks passing by reference better

Comment #12

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 8 August 2016 at 16:13

File	Size
interdiff.txt	2.31 KB
2724281-12.patch	4.78 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 Patch failed to apply

Closed as duplicate also passing array by reference keeps memory usage low

Comment #13

8 August 2016 at 16:15

Status:

Needs review

» Needs work

The last submitted patch, 12: 2724281-12.patch, failed testing.

Comment #14

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 8 August 2016 at 16:18

Status:

Needs work

» Needs review

File	Size
interdiff.txt	1.2 KB
2724281-15.patch	4.83 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 4 pass

Comment #16

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan at PreviousNext commented 8 August 2016 at 22:25

+++ b/src/DefaultContentManager.php
@@ -319,30 +319,51 @@ class DefaultContentManager implements DefaultContentManagerInterface {
+    return $entity->getEntityTypeId() . ':' . $entity->id();

Any reason we can't use $entity->uuid() here instead?

Other than that, looks RTBC to me.

Comment #17

gaydabura CreditAttribution: gaydabura as a volunteer and at Skilld commented 9 August 2016 at 03:52

Status:

Needs review

» Reviewed & tested by the community

@andypost, much better then detect max level.
@larowlan actually this hash is temporary and uuid is in returned array as key.
http://cgit.drupalcode.org/default_content/tree/src/DefaultContentManage...
RTBC to me aswell

Comment #18

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 9 August 2016 at 05:21

Status:	Reviewed & tested by the community	» Needs work
Issue tags:		+Needs tests

I think we need tests for nesting
Also uuid vs hash is a good question, the main idea is to keep that key easy to debug

OTOH as @Alexey pointed we already use uuid to index

Comment #19

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 10 August 2016 at 13:53

Parent issue:

» #2770969: Schedule a beta release

Comment #20

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 18 August 2016 at 22:46

Status:	Needs work	» Needs review
Issue tags:	-Needs tests

File	Size
interdiff.txt	4.6 KB
2724281-recursion-test-only.patch	1.93 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 3 pass, 1 fail
2724281-recursion-20.patch	6.58 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 4 pass

2 files were hidden/shown/deleted

File	Size
interdiff.txt	2.31 KB
interdiff.txt	1.2 KB

Removed key gen method and using uuid
Here's a test, before patch only 2 entities are exported

Comment #21

18 August 2016 at 22:48

The last submitted patch, 20: 2724281-recursion-test-only.patch, failed testing.

Comment #22

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan at PreviousNext commented 18 August 2016 at 23:04

Status:

Needs review

» Reviewed & tested by the community

Looks good to me.

Will leave at RTBC till Monday then commit

Comment #23

15 September 2016 at 21:44

larowlan committed 10c07ee on 8.x-1.x authored by andypost

Issue #2724281 by andypost, pguillard, larowlan, chr.fritsch, jwilson3,...

Comment #24

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan at PreviousNext commented 15 September 2016 at 21:44

Status:

Reviewed & tested by the community

» Fixed

Fixed - thanks!

Comment #25

29 September 2016 at 21:44

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Fatal error: Nesting level too deep

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Comment #22

Comment #23

Comment #24

Comment #25

Parent issue

Related issues

Referenced by

Thank you to these Drupal contributors

News items

Our community

Documentation

Drupal code base

Governance of community