Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Not following Drupal Code Standards
Proposed resolution
Run Coder module over SMTP module and fix all issues.
Comment | File | Size | Author |
---|---|---|---|
#8 | smtp-coding_standards-2751623-8-D7.patch | 2.28 KB | Sagar Ramgade |
#2 | code_standards-2751623-1.patch | 2.19 KB | davi.uezono |
Comments
Comment #2
davi.uezono CreditAttribution: davi.uezono at CI&T commentedFixed all issues in this version
Comment #3
davi.uezono CreditAttribution: davi.uezono at CI&T commentedComment #4
davi.uezono CreditAttribution: davi.uezono at CI&T commentedComment #5
davi.uezono CreditAttribution: davi.uezono at CI&T commentedComment #6
davi.uezono CreditAttribution: davi.uezono at CI&T commentedComment #7
wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commentedNeed re-roll
Comment #8
Sagar Ramgade CreditAttribution: Sagar Ramgade as a volunteer and at Trigyn Technologies Ltd commentedPatch re-rolled.
Comment #9
renatogIn review.
Comment #10
renatogHi!
I applied the patch and looks good for me.
+RTBC.
Regards.
Comment #11
renatogHello @wundo, how are u?
Patch #8 makes sense for you? If yes, Can you commit in the dev branch?
Thanks
Comment #13
wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commentedFixed