Problem/Motivation
Follow-up from #2750167: Config translation synchronization fails
Proposed resolution
Re save all configuration. We can't really know how all config overrides have implemented \Drupal\Core\Config\ConfigFactoryOverrideBase() so the safest thing to do is just to re-save all configuration and let the save event clean up for us.
Remaining tasks
User interface changes
None
API changes
None
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#10 | 2776357-10.patch | 6.32 KB | alexpott |
#10 | 7-10-interdiff.txt | 1.39 KB | alexpott |
#7 | 2776357-7.patch | 6.23 KB | alexpott |
Comments
Comment #2
alexpottAdding all the related issues.
Comment #3
alexpottComment #5
alexpottDiscussed with @xjm, @webchick, @effulgentsia and @Cottser. We agreed to keep this critical because:
Comment #6
xjmComment #7
alexpottHere's the whack it with a hammer upgrade path approach.
Comment #8
xjmThe beta allowed changes include critical issues, so the beta target tag is not applicable.
Comment #9
dawehnerI agree with alex, its not really worth to try to optimize the update here. In case we miss any case, it will hurt much more, than a little bit more time to run the update.
Can we use something like
assertNull
?Its weird to not have splitted up this into two assertions. It makes debugging harder than it would have to be
Comment #10
alexpottRe #9.2 I did that because isNew() should be enough and doing it on separate lines looks weird to me. But so be it... here's the change.
Comment #11
dawehnerThank you alex!
Comment #14
catchCommitted/pushed to 8.3.x and cherry-picked to 8.2.x. Thanks!
Comment #15
alexpottLet's hope no one is doing anything made on config save... mind you if they are config import would probably be broken too.
Comment #16
Gábor HojtsyWow, thanks!