Login redirect not working

Thanks for reminding. Yeah, the first D8 release was a very basic release with very basic functionality. We will be implementing this soon. Assigning to Tcraw.

1. +++ b/config/install/prlp.settings.yml
   @@ -1,2 +1,2 @@
   -login_destination: user/%uid/edit
   
   +++ b/prlp.module
   @@ -7,11 +7,6 @@
   -define('PRLP_DESTINATION_DEFAULT', 'user/%uid/edit');
   

   I'd better keep ability to configure destination
   but probably better to file separate issue for http://cgit.drupalcode.org/prlp/tree/src/Controller/PrlpController.php?h...

2. +++ b/src/Controller/PrlpController.php
   @@ -81,6 +82,12 @@ class PrlpController extends UserController {
   +        return new RedirectResponse($login_destination, 302);
   

   302 is the default in SF

@andypost I didn't remove this config completely.
By default login_destination config value is empty.
Destination is hardcoded in line http://cgit.drupalcode.org/prlp/tree/src/Controller/PrlpController.php?h...
and pointed to internal uri user/%uid/edit.

If we want to override destination url we need check Override destination checkbox and specify login_destination config.
Then these settings can be exported.

The patch seems to work pretty well. One problem though is that you get a bad request error if you leave the %uid token in there. I think we need to dynamically replace this before issuing the redirect.

Updated the patch to be able to handle the %uid token.

I fail to see what the purpose of the override checkbox is (suggested in #5).

The code should be written to either set the default value (if the configuration value is default or empty) or accept a custom value (if the value is configured).

I would also suggest to set the user token to %user instead of %uid, as this token already refers to a user in Views.

Suggested patch is attached.

Hi,

I tried your different patches but redirection is still not working.
I have "Access denied"...

Any idea ?

Thanks

Patch from #8 works great against version 1.3.

Only thing I noticed is that the "%front" replacement is no longer available, but I could just enter "/" to redirect to the frontpage.

Revised patch from #8 to include support of the '%front' replacement mentioned in #10. Interdiff included.

Patch works great.

Bumping to high priority since the whole point of this module is to improve UX, but without this functionality it's no better than Core.

Would be great to use the token system rather than these custom ones, but that's something for a separate issue.

Thanks!
patch https://www.drupal.org/project/prlp/issues/2785087#comment-12218421 is working perfect for me (drupal 8.5.1 and prlp 1.3 and redirect path is /products)

Thank you all for providing patches. I have committed the patch to 8.x-1.x branch.

@jitesh-doshi

Apparently you forgot to push the release after applying the patch. This code is not currently on the stable release and I doubt that it is on the dev release which is much older.

I had to apply the patch locally.

Thank you for this module. Very helpful.

Hi,

The last release of the module doesn't contain this patch. The issue is still here, I was able to fix it after applying the patch.

Thanks for the module, it's very useful.

Sorry @abhou and @jcmartinez. The fix was committed, but only available on the DEV branch. I have now cut a new release (8.x-1.4) that actually contains the fix for this issue.