API page: https://api.drupal.org/api/drupal/modules%21filter%21filter.api.php/func... and https://api.drupal.org/api/drupal/modules%21filter%21filter.api.php/func...

$text = preg_replace('|<code>(.+?)|se', "[codefilter_code]$1[/codefilter_code]", $text);

The e option is deprecated in PHP 5.5, and removed in PHP 7. (Also, it doesn't do anything in the example.)

CommentFileSizeAuthor
#21 filter_api_issue_fixed.png32.63 KBravikk-drupal
#18 filter-deprecated-e-option-preg-2788565-18.patch1.05 KBsjerdo
#12 removing-deprecated-regex-2788565-7.x.patch1.06 KBlhuria94
#9 removing-deprecated-regex-2788565-7.x.patch1.06 KBlhuria94
#5 2788565-5.patch1.05 KBshashikant_chauhan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

joachim’s picture

joachim CreditAttribution: joachim commented
Title: sample for for callback_filter_process() and callback_filter_prepare() should not include deprecated regex option » sample code for callback_filter_process() and callback_filter_prepare() should not include deprecated regex option
rashid_786’s picture

rashid_786 CreditAttribution: rashid_786 commented

According to you it should be without 'e' option like the following line?

$text = preg_replace('|<code>(.+?)|s', "[codefilter_code]$1[/codefilter_code]", $text);

joachim’s picture

joachim CreditAttribution: joachim commented

Yup, that looks fine. The 'e' option wasn't doing anything anyway, since the replacement parameter isn't executable code.

shashikant_chauhan’s picture

shashikant_chauhan CreditAttribution: shashikant_chauhan as a volunteer and at Iksula commented
FileSize
2788565-5.patch1.05 KB

adding patch.

shashikant_chauhan’s picture

shashikant_chauhan CreditAttribution: shashikant_chauhan as a volunteer and at Iksula commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 5: 2788565-5.patch, failed testing.

Sutharsan’s picture

Sutharsan CreditAttribution: Sutharsan commented
Issue tags: +Dublin2016
lhuria94’s picture

lhuria94 CreditAttribution: lhuria94 at Srijan | A Material+ Company commented
FileSize
removing-deprecated-regex-2788565-7.x.patch1.06 KB

Remove preg_replace() & se as it is deprecated and suggested to preg_replace_callback().

lhuria94’s picture

lhuria94 CreditAttribution: lhuria94 at Srijan | A Material+ Company commented
Status: Needs work » Needs review
joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Needs work

These don't need to be preg_replace_callback() -- AFAICT there is no executable code in the replacement.

lhuria94’s picture

lhuria94 CreditAttribution: lhuria94 at Srijan | A Material+ Company commented
FileSize
removing-deprecated-regex-2788565-7.x.patch1.06 KB

Updated patch. Ignore previous one please.

lhuria94’s picture

lhuria94 CreditAttribution: lhuria94 at Srijan | A Material+ Company commented
Status: Needs work » Needs review
somersoft’s picture

somersoft CreditAttribution: somersoft commented
Related issues: +#3006195: Error with PHP7
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave as a volunteer commented

Closed the following as duplicates:

#2843864: Examples in filter.api.php use deprecated regular expression modifier "e"
#2943290: filter.api.php is insecure and does not pass php7 tests
#3006195: Error with PHP7

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Suggested patch looks fine to me, I agree with #11, and ultimately it doesn't really matter as this is just sample code in documentation, it's not really used for anything.

John Morahan’s picture

John Morahan CreditAttribution: John Morahan as a volunteer commented
Status: Reviewed & tested by the community » Needs work

#12 doesn't look right to me... \s*<br /> as a modifier? And I get a warning if I try to run it: preg_replace(): Unknown modifier '\'

sjerdo’s picture

sjerdo
Primary language Dutch
Location Haarlem
CreditAttribution: sjerdo at Synetic commented
Status: Needs work » Needs review
Issue tags: +PHP 7.0 (duplicate)
FileSize
filter-deprecated-e-option-preg-2788565-18.patch1.05 KB

Patch #5 looks good to me.
Rebased patch #5.

dan2k3k4’s picture

dan2k3k4 CreditAttribution: dan2k3k4 at Amazee Labs commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

ravikk-drupal’s picture

ravikk-drupal CreditAttribution: ravikk-drupal at TATA Consultancy Services for Pfizer, Inc. commented
Assigned: Unassigned » ravikk-drupal
ravikk-drupal’s picture

ravikk-drupal CreditAttribution: ravikk-drupal at TATA Consultancy Services for Pfizer, Inc. commented
FileSize
filter_api_issue_fixed.png32.63 KB

This patch perfectly works for me. Screenshot attached for the same.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Issue tags: +PHP 7.4
apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Assigned: ravikk-drupal » Unassigned
mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid as a volunteer and at Acquia commented
Issue tags: +Pending Drupal 7 commit

LGTM

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented
Parent issue: » #3081386: [META] Fully support PHP 7.4 in Drupal 7
Fabianx’s picture

Fabianx CreditAttribution: Fabianx at Tag1 Consulting commented

Approved, RTBM.

Let's get this in!

Fabianx’s picture

Fabianx CreditAttribution: Fabianx at Tag1 Consulting commented
Assigned: Unassigned » mcdruid

  • mcdruid committed 9ed3f67 on 7.x 
    Issue #2788565 by lhuria94, shashikant_chauhan, sjerdo, ravikk-drupal,...
mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid at Acquia commented
Assigned: mcdruid » Unassigned
Status: Reviewed & tested by the community » Fixed
Issue tags: -Pending Drupal 7 commit

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.