When running TinyMCE in Firefox 3.0, Firefox's native spellcheck is disabled.

CommentFileSizeAuthor
#1 tinymce.module.patch99 bytesAren Cambre
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Aren Cambre’s picture

FileSize
99 bytes

http://wiki.moxiecode.com/index.php/TinyMCE:Configuration/gecko_spellcheck says this is actually default configuration.

http://drupal.org/node/135150 suggests the fix isn't really causing problems.

Patch attached.

Aren Cambre’s picture

Status: Active » Needs review

Updating status.

kscheirer’s picture

Status: Needs review » Needs work

please use unified format and patch from the drupal root, see http://drupal.org/patch/create

TomChiverton’s picture

# diff -u modules/wysiwyg/editors/tinymce.inc.orig modules/wysiwyg/editors/tinymce.inc
--- modules/wysiwyg/editors/tinymce.inc.orig 2009-06-06 20:02:14.000000000 +0100
+++ modules/wysiwyg/editors/tinymce.inc 2009-06-06 20:03:09.000000000 +0100
@@ -128,6 +128,7 @@
// TinyMCE's URL conversion magic breaks Drupal modules that use a special
// syntax for paths. This makes 'relative_urls' obsolete.
'convert_urls' => FALSE,
+ 'gecko_spellcheck' => TRUE,
);
if (isset($config['apply_source_formatting'])) {
$init['apply_source_formatting'] = $config['apply_source_formatting'];

TomChiverton’s picture

For 2.0 release:
# diff -u wysiwyg/editors/tinymce.inc.orig wysiwyg/editors/tinymce.inc
--- wysiwyg/editors/tinymce.inc.orig 2009-06-12 18:36:27.000000000 +0100
+++ wysiwyg/editors/tinymce.inc 2009-06-12 18:36:55.000000000 +0100
@@ -156,6 +156,7 @@
// HTML control characters and invisible characters. TinyMCE always converts
// XML default characters '&', '<', '>'.
'entities' => '160,nbsp,173,shy,8194,ensp,8195,emsp,8201,thinsp,8204,zwnj,8205,zwj,8206,lrm,8207,rlm',
+ 'gecko_spellcheck' => TRUE,
);
if (isset($config['apply_source_formatting'])) {
$settings['apply_source_formatting'] = $config['apply_source_formatting'];

kscheirer’s picture

@Tom

Almost there! check out http://drupal.org/patch/create, under Quick start example (diff). You want to run something more like diff -up path/to/file/example.module path/to/file/exampleNew.module > mypatchname.patch, and then attach the resulting file to this issue, and set the Status field to "needs review". This will let the maintainer know that you've got some code for him/her to look at, and its easy for them to download and apply your patch with one command.

davoodr’s picture

teest

nicoloye’s picture

Issue summary: View changes
Status: Needs work » Closed (outdated)