Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi,
I installed phptemplate and Blumarine for phptemplate.
However, it has very serious bugs in node display. You can see what I mean here and here.
Everything is ok on the homepage, but when you click on a node to read it, you see grey background if it is sticky, and not white as it appears with Bluemarine xtemplate. Also, when you click on a node to see it, you see twice its title, and one title is clickable, which is totally wrong and this does not happen with bluemarine for xtemplate.
Comment | File | Size | Author |
---|---|---|---|
#10 | nskdiff | 475 bytes | nsk |
#6 | node.tpl_0.php | 586 bytes | nsk |
#4 | node.tpl.php | 533 bytes | nsk |
Comments
Comment #1
nsk CreditAttribution: nsk commentedThe double title bug is related to the Taxonomy Menu module, but the gray background if sticky in node view bug is not related to Taxonomuy Menu,
Comment #2
nsk CreditAttribution: nsk commentedI fixed the sticky bug. Here is the code: in node.tpl.php for 4.6:
print $node_url">
print $title
print $submitted
print $terms
print $content
print $links
Comment #3
nsk CreditAttribution: nsk commentednode.tpl.php:
Comment #4
nsk CreditAttribution: nsk commentedsee attach
Comment #5
nsk CreditAttribution: nsk commentedthe patch I uploaded has a smaller bug, too: taxonomy pages don't get stickies, I am working on this...
Comment #6
nsk CreditAttribution: nsk commentedhey I solved the taxonomy bug too!
Comment #7
robertDouglass CreditAttribution: robertDouglass commentedIf you could generate a patch from this it would be useful. Thanks.
Comment #8
nsk CreditAttribution: nsk commentedI have an account in the contribs repository so I think maybe I could update the CVS directly if you want me to do so.
Comment #9
nsk CreditAttribution: nsk commented--- node-original.tpl.php 2004-12-26 04:25:08.000000000 +0200
+++ node-bugfix.tpl.php 2005-08-03 21:40:53.000000000 +0300
@@ -1,4 +1,4 @@
-
+
Comment #10
nsk CreditAttribution: nsk commentedI wish I could paste raw text. See the file
Comment #11
nsk CreditAttribution: nsk commentedI documented my bugfix, here
Comment #12
nsk CreditAttribution: nsk commentedhey in the taxocheck add "|| $mytaxocheck == 'taxonomy_menu'" to make the background colour work even in taxonomy menu.
Comment #13
gordon CreditAttribution: gordon commentedI have looked at the issue that has been described, and I have also looked at other phptemplate themes. bluemarine respects the sticky flag unconditionally.
You can alter this in your copy of bluemarine but then you have a non-standard version. If you consider this a problem then it is the phptemplate engine that is passing the $sticky flag incorrectly and should be fixed in their so all other phptemplate themes have this fix as well.
Comment #14
nsk CreditAttribution: nsk commentedThe fact that the bug is in PHPTemplate does not mean that you should allow it
to propagate within the theme. There is nothing wrong with fixing an engine
bug on the theme level. When the person responsible for PHPTemplate fixes the
bug there, you will just provide a new version of Bluemarine without the
theme-level extra fix. The user does not care where the bug is or what causes
it, not ever whether the bug appears in other themes and other sites, they
care only about correct HTML output in their own website, and that's what we
should strive to provide. Since our code is used on production sites we
should first try to provide proper output, then do the right job inside the
code. So, if we cannot fix the PHPTemplate bug right now, we should apply a
theme-level fix, as I do on http://portal.wikinerds.org/
The fix in node.tpl.php is easy:
I built that code based on information from #drupal and what I do is just
checking the URL to see whether we are in the main page or in a taxonomy page
or in a taxonomy_menu page. If that's true then the normal sticky code
executes.