Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Currently listed tours in help page have links generated to pages where tour is available. When you click on tour, you get redirected to page, but tour does not start. In this case user went to page, because of tour and it would be useful if tour automatically starts. I think it's expected behaviour.
Proposed resolution
Append "tour=1" parameter to generated page link and tour will be displayed automatically.
Remaining tasks
- Add defined functionality in tour module. Related class should be:
modules/tour/src/Plugin/HelpSection/TourHelpSection.php
Comment | File | Size | Author |
---|---|---|---|
#23 | 2844897-23.patch | 4.48 KB | yogeshmpawar |
#23 | interdiff-2844897-19-23.txt | 1.92 KB | yogeshmpawar |
#19 | tour-help-links-2844897-19.patch | 4.46 KB | thejimbirch |
Comments
Comment #2
mtodor CreditAttribution: mtodor at Thunder commentedHere is proposed solution.
Comment #3
dawehnerThat's a really nice change! Do you think we can provide test coverage for that?
Comment #5
realityloop+1
Comment #6
realityloopMissed dawehner's comment about tests
Comment #7
mtodor CreditAttribution: mtodor at Thunder commentedHere are tests for this functionality. There is also patch only with tests and that's at same time a interdiff.
And additionally we are rolling this out with 8.4.x.
Comment #10
mtodor CreditAttribution: mtodor at Thunder commentedComment #19
thejimbirch CreditAttribution: thejimbirch at Kanopi Studios commentedVery smart idea. Love it!
Patch attached that re-rolls the patch in #7 for Drupal 9.3
I applied the patch to a local site and recorded a screenshot of it working as expected.
Fingers crossed the test passes.
Comment #21
thejimbirch CreditAttribution: thejimbirch at Kanopi Studios commentedI'm going to need help with that failing test. A bit beyond me.
Comment #22
yogeshmpawarworking on test failures.
Comment #23
yogeshmpawarAdded patch which will remove test failures & also added an interdiff for the same to review.
Comment #29
quietone CreditAttribution: quietone at PreviousNext commentedThis extension is being deprecated, see #3336033: [Meta] Tasks to deprecate Tour module. It will be removed from core and moved to a contrib project, #3376099: [11.x] [Meta] Tasks to remove Tour.
This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.
Comment #30
quietone CreditAttribution: quietone at PreviousNext commented