Support flags on generated nodes [#285137]

devel_generate.module is a great way to create dummy nodes on your site. It now works works with CCK to fill in all those fields with dummy data and OG adds dummy group relationships as well.

So, i'd like for generated nodes to have flags added. For global flags you just add a TRUE or FALSE for each flag that applies to the content type. For user flags, you just create a few flag instances for some random users. Ideally, you would respect role configuration.

You should do this by implementing hook_nodeapi('presave'). In that hook, look do this:


if ($node->devel_generate) {
  // Inject your data into $node
  $node->flag = [STUFF]
}

Comments

Comment #1

mitchell CreditAttribution: mitchell commented 17 May 2009 at 01:22

Status:

Active

» Fixed

I think you would have to use the actions system unless there's another method for programmatically flagging. Flag includes support for both trigger and rules.

Marking as fixed, but I'm personally still interested in other ways.

Comment #2

quicksketch

he/him

CreditAttribution: quicksketch commented 17 May 2009 at 01:59

Status:

Fixed

» Active

Thanks for cleaning up issues mitchell, but this request is not about actions at all, it's about using the devel generate module to programatically create nodes. A lot of modules support devel generate (like CCK and Organic Groups), and it'd make sense if Flag provided this support as well by implementing hook_content_generate() to randomly populate nodes with flagged statuses.

Comment #3

joachim CreditAttribution: joachim commented 1 August 2012 at 07:08

Version:	6.x-1.x-dev	» 7.x-3.x-dev
Component:	Code	» Flag core

Comment #4

socketwench CreditAttribution: socketwench commented 29 December 2012 at 04:02

If someone could point me to some example code, I could work on this.

Comment #5

joachim CreditAttribution: joachim commented 3 January 2013 at 09:04

Looking at devel_generate_content_add_node(), this only calls a helper to add field data. And devel_generate_fields() only invokes a function for the module owner of a field type.

Admittedly this is a very quick glance I've had at the code, so I could be wrong, but I don't think there's a nice way for us to support this.

Comment #6

joachim CreditAttribution: joachim commented 3 January 2013 at 09:08

Yup, I think we'd have to patch devel so that devel_generate_content_add_node() or devel_generate_node_insert() invokes a hook -- probably the latter so there's a nid. The comment and statistics code should then be moved to hook implementations probably.

Comment #7

moshe weitzman CreditAttribution: moshe weitzman commented 3 January 2013 at 15:39

See my example code in the OP. That runs during your presave hook. No devel patch needed.

Comment #8

joachim CreditAttribution: joachim commented 3 January 2013 at 16:25

I'd rather not have to pollute the main workflow with code for a developer use case. My preferred scenario would be a hook we can stick in a flag.devel.inc or something.

Or indeed, barring that, we could stick it in flag_devel module itself?

Comment #9

moshe weitzman CreditAttribution: moshe weitzman commented 3 January 2013 at 16:49

i personally think a flag_devel module is poor dx for the users but whatever flag maintainers want to do is fine. devel isn't planning on duplicating presave hook.

Comment #10

joachim CreditAttribution: joachim commented 3 January 2013 at 16:54

> i personally think a flag_devel module is poor dx for the users

I'm inclined to agree.

But most sites won't be running Devel generate -- surely this is meant for development copies only. So how is it good DX to have code just for that in the main flow?

Comment #11

moshe weitzman CreditAttribution: moshe weitzman commented 3 January 2013 at 20:22

Sorry, I meant UX there. So, I favor UX over DX here. It is arguably not even a regression in DX because hiding functonality in many small helper files has its own annoyance. Anyway, feel free to put everything but the hook declaration in an include file. And now I've said all I want to say on this issue. Thanks for Flag!