Fixed settings and delta not used in 8.x-3.x-dev [#2869235]

Hi people, how are you?

Congrats on the project. Field Collection is very useful.

I fixed settings and delta not used in branch 8.x-3.x-dev.

Comment	File	Size	Author
#2	field_collection-fixed_settings_deta-2.patch	1.61 KB	renatog
#2	8.x-3.x: PHP 5.5 & MySQL 5.5, D8.4 11 pass
	8989.png	108.5 KB	renatog
	89.png	108.23 KB	renatog

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

12 April 2017 at 23:32

RenatoG created an issue. See original summary.

Comment #2

renatog

Campinas

CreditAttribution: renatog at CI&T commented 12 April 2017 at 23:32

Assigned:	renatog	» Unassigned
Status:	Active	» Needs review

File	Size
field_collection-fixed_settings_deta-2.patch	1.61 KB
8.x-3.x: PHP 5.5 & MySQL 5.5, D8.4 11 pass

The patch with fix it's in attachment.

Good Work.

Regards.

Comment #3

ram4nd CreditAttribution: ram4nd as a volunteer commented 20 October 2019 at 14:19

Status:	Needs review	» Closed (won't fix)
Issue tags:	-ciandt-contrib

Comment #4

renatog

Campinas

CreditAttribution: renatog at CI&T commented 21 October 2019 at 12:28

Status:

Closed (won't fix)

» Active

Hello @ram4nd, how are you?

The patch is useful to remove an unused variables, and it really makes sense, right?!

Comment #5

21 October 2019 at 12:28

RenatoG committed 3a75aa5 on 8.x-3.x

Issue #2869235 by RenatoG: Fixed settings and delta not used in 8.x-3.x-...

Comment #6

renatog

Campinas

CreditAttribution: renatog at CI&T commented 21 October 2019 at 12:50

Status:

Active

» Fixed

Committed to the dev branch.

Remove unused variable is a best practice as https://www.drupal.org/docs/develop/standards

P.s. Field Collection is not necessary for D8, but we've 15,742 using D8 code yet. If we have code for D8 is a good idea to use best practice recommendations.

Thank you so much, have a good week.

Best,