Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Child issue of #2873705: Add change records to all @deprecated code.
Add change record links to @deprecated items in bootstrap.inc.
Comment | File | Size | Author |
---|---|---|---|
#15 | interdiff-2873796-11-15.txt | 2.87 KB | pritish.kumar |
#15 | 2873796-bootstrap-inc-15.patch | 2.94 KB | pritish.kumar |
#11 | 2873796-bootstrap-inc-11.patch | 2.91 KB | davidneedham |
#9 | 2873796-bootstrap-inc-2.patch | 2.91 KB | kwhite |
#3 | 2873749_2.patch | 579 bytes | dietric@gmail.com |
Comments
Comment #2
dietric@gmail.comComment #3
dietric@gmail.comHere's the patch for this
Comment #4
johnshortessI'm seeing extra whitespace at the end of the two added comment lines. Other than that, it looks like the patch is linking to the correct change records, and the format of the comment matches the format from the parent issue.
I believe @Dietrich Schmidt has already left the sprint -- can anyone else reroll this patch to fix the whitespace issue?
Comment #5
kwhiteI was working on other deprecation tags in this file. Can I roll all of them together? If so happy to take this on...
Comment #6
johnshortess@kwhite I think that would be fine. Just please be sure to add @Dietrich Schmidt on your issue so he gets credit for his patch! Thanks!
Comment #7
kwhiteWill do!
Comment #8
kwhiteWait.... how do I do that @johnshortess??? Issue is here: https://www.drupal.org/node/2873796
Comment #9
kwhiteMade the whitespace adjustments and also added change records for the other deprecated flags in the file. Patch attached.
Comment #10
kwhiteComment #11
davidneedhamThis is very close! Everything looks good to me except for the next to last change - lines
This (https://www.drupal.org/node/2235431) seems to be an old change record that isn't specific enough to this particular function. It uses drupal_get_profile() in the example (which doesn't quite seem appropriate if it's depreciated) and doesn't mention that the function itself is being depreciated.
I think https://www.drupal.org/node/2538996 is closer. Part-way down it says: "To access the install profile in Drupal 8 use \Drupal::installProfile() or inject the install_profile container parameter into your service." (which matches the comment) as well as "drupal_get_profile() has been deprecated and will be removed in Drupal 9."
I rerolled the patch with this change. Leaving the status on "Needs Review".
Comment #12
cosmicdreams CreditAttribution: cosmicdreams commentedModifying title to reflect current scope of issue.
Comment #13
cosmicdreams CreditAttribution: cosmicdreams commentedI reviewed the previous patch and David's change. Looks good to me.
Comment #14
catchThanks for this!
We should remove the reference to SafeMarkup::format() here, since SafeMarkup itself has been deprecated.
Let's just add the reference to 2302363, the older change record is made obsolete by that one.
Comment #15
pritish.kumar CreditAttribution: pritish.kumar at OpenSense Labs commentedDid the changes as specified in #14. Please check if it's correct.
Comment #16
gaurav.kapoor CreditAttribution: gaurav.kapoor at OpenSense Labs commentedComment #17
catchThanks! Patch looks good now so moving back to RTBC.
Comment #19
Gábor HojtsyComment #22
xjmRemoving the issue relationship from fixed issues to keep the parent issue usable. Thanks!