Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Child issue of #2873705: Add change records to all @deprecated code. Add Change record to @deprecated functions in file.inc
Comment | File | Size | Author |
---|---|---|---|
#6 | interdiff-2-6.txt | 1.25 KB | gaurav.kapoor |
#6 | 2873775-6.patch | 5.31 KB | gaurav.kapoor |
#3 | 2873775_2.patch | 4.06 KB | josephcheek |
#2 | 2873775_1.patch | 519 bytes | josephcheek |
Comments
Comment #2
josephcheekhey i created a patch for this! with @cosmicdreams' help!
Comment #3
josephcheekI decided to roll a single patch for all deprecated functions in this CR (@see https://www.drupal.org/node/2418133)
Comment #4
John Cook CreditAttribution: John Cook at Creode commentedThere are only
@see
comment tags referring to the change log added in this patch.After searching through the code, I couldn't find any missed deprecated functions that required the comment to be updated.
Because of this, I'm marking as RTBC.
Comment #5
cilefen CreditAttribution: cilefen commentedThank you all.
file_directory_os_temp() and file_htaccess_lines() fall into the scope of the issue title but did not get @sees. file_directory_os_temp() has a change record.
I am going to ask on the parent issue about what we are to do about deprecated constants.Also, there are constants that did not get @sees.Comment #6
gaurav.kapoor CreditAttribution: gaurav.kapoor at OpenSense Labs commentedComment #7
John Cook CreditAttribution: John Cook at Creode commented@sees have been added to
file_directory_os_temp()
,file_htaccess_lines()
, and the deprecated constants from cilefen's comment.Again, I can't see anything else, but I missed some last time.
I'm setting to RTBC (until cilefen finds something else ;) ).
Comment #10
Gábor HojtsyI verified that all functions and constants mentioned in the change notice got a @see (this is the reverse of what John Cook verified, so its validated both ways now). Thanks all!
Comment #11
xjmComment #12
xjm(Just removing the issue relationship and instead mentioning this issue in the summary.)