Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2873867-core-services-yml-docs.patch | 836 bytes | kwhite |
Comments
Comment #2
kwhitePatch for the change record for config.storage.staging.
There's one other @deprecated tag in this file (line 531, entity.manager), but I can't find an appropriate change record, so I'm leaving it as-is.
Comment #3
kwhiteComment #4
clairedesbois@gmail.comI confirm the change is correct.
Additionnally, the function getStaging seems had been removed in the class FileStorageFactory so it's not necessary to document it.
Comment #5
clairedesbois@gmail.comComment #6
xjmComment #9
xjmAs described in #2887156: Add change record link @deprecated for the CMI staging, there are three changes included in https://www.drupal.org/node/2574957. One (the constant) has already been documented in #2873749: Add change record links to @deprecated items in bootstrap.inc, the second (the method) was just directly renamed and so does not need documentation, and the third (the service) is covered in this patch.
My one question was whether we should use
@seein a YAML file, but we already do this in several other places in core, so that makes sense too.Thanks @Calystod and @kwhite! Committed and pushed to 8.4.x. I also backported this to 8.3.x since it is a documentation improvement (reference: https://www.drupal.org/core/d8-allowed-changes#patch).
Comment #11
kay_v CreditAttribution: kay_v as a volunteer commentedRemoving parent issue per conversation with @xjm at Drupalcon Nashville Mentored Sprint prep. Her recommendation to do so was based on a few points that made sense to all of us in the discussion, namely:
- so many child issues makes this parent unwieldy
- search filters will allow people needing to refind closed children