[D8] Workbench Moderation Actions

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectworkbench_moderation...

I'm a robot and this is an automated message from Project Applications Scraper.

Hey nicrodgers,

I checked your module, however there are some coding issues and recommendations that you may be interested in :

FILE: /root/repos/pareviewsh/pareview_temp/src/Controller/StateChange.php
-------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-------------------------------------------------------------------------
14 | ERROR | Doc comment is empty
19 | ERROR | Missing short description in doc comment
24 | ERROR | Missing short description in doc comment
-------------------------------------------------------------------------

FILE: ...oot/repos/pareviewsh/pareview_temp/src/Plugin/Action/StateChange.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
26 | ERROR | Missing short description in doc comment
31 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------

FILE: ...s/pareviewsh/pareview_temp/src/Plugin/Deriver/StateChangeDeriver.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
12 | ERROR | Doc comment is empty
17 | ERROR | Missing short description in doc comment
22 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------

FILE: .../repos/pareviewsh/pareview_temp/workbench_moderation_actions.install
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------

FILE: ...t/repos/pareviewsh/pareview_temp/workbench_moderation_actions.module
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------

FILE: ...root/repos/pareviewsh/pareview_temp/tests/src/Kernel/DeriverTest.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
14 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------

Thank you.

@nicrodgers

Actually, we are trying to provide feedback based on automated review. I disagree that sometimes it is very helpful for developer to understand logic of code based on comments. So, it is better to add proper comments based on coding standard.

If you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.

I updated the issue summary (only).

Thank you for the contribution!

Please use for the project/module "Automated testing" (https://www.drupal.org/node/2891271/qa) at least PHP >= 7.1 & MySQL 5.7

I did not find security related issues and set the issue status to Reviewed & tested by the community.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.