PHP Error: Call to a member function get() on boolean

Steps to reproduce and patches welcome.

This isn't related to #2769237: PHP Fatal error: Call to a member function label() on boolean , by any chance?

Hey @heddn,

We are also facing the same problem and occurrence of this issue is at random intervals. Once we clear cache, it goes away but after running migration twice, it comes back.

We generally see this error while executing - `drush ms` and we are using latest version(8.x-4.0-beta1) of migrate_tools module.

Updating both migrate_plus & migrate_tools modules to 8.x-4.0-beta1 fixes the above issue.

i got this on UI
http://d8/admin/structure/migrate/manage/migrate_drupal_7/migrations
with the latest 8.4.dev

here is the "wsod" full message

The website encountered an unexpected error. Please try again later.
Error: Call to a member function get() on boolean in Drupal\migrate_tools\Controller\MigrationListBuilder->buildRow() (line 145 of modules/contrib/migrate_tools/src/Controller/MigrationListBuilder.php).

Drupal\migrate_tools\Controller\MigrationListBuilder->buildRow(Object) (Line: 233)
Drupal\Core\Entity\EntityListBuilder->render() (Line: 22)
Drupal\Core\Entity\Controller\EntityListController->listing('migration')
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 582)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 657)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

I'm changing this to critical because this error happens even with the Beer migrations in migrate_example, and it make migrate_tools unusable - I cannot run a single migration.

At the same time, drush migrate-status displays an empty table, with no migrations in it. I guess it is due to this exact bug.

I had the same problem because composer had installed the wrong version of Migrate Plus - an 8.2 version.

Using 4.0-beta3 for both Migrate Plus and Migrate Tools works for me.

Using 4.0-beta3 for both Migrate Plus and Migrate Tools works for me.

+1 for this. This has been driving me nuts for days now.

Using 4.0-beta3 for the two modules migrate_plus and migrate_tools still raise an exception for me:

The website encountered an unexpected error. Please try again later.
TypeError: Argument 1 passed to Drupal\migrate\Plugin\Migration::getProcessNormalized() must be of the type array, null given, called in /app/web/core/modules/migrate/src/Plugin/Migration.php on line 630 in Drupal\migrate\Plugin\Migration->getProcessNormalized() (line 391 of core/modules/migrate/src/Plugin/Migration.php).
Drupal\migrate\Plugin\Migration->getProcessNormalized(NULL) (Line: 630)
Drupal\migrate\Plugin\Migration->findMigrationDependencies(NULL) (Line: 618)
Drupal\migrate\Plugin\Migration->getMigrationDependencies() (Line: 122)
Drupal\migrate\Plugin\MigrationPluginManager->createInstances(Array, Array) (Line: 100)
Drupal\migrate\Plugin\MigrationPluginManager->createInstance('my_custom_migration') (Line: 144)
Drupal\migrate_tools\Controller\MigrationListBuilder->buildRow(Object) (Line: 233)
Drupal\Core\Entity\EntityListBuilder->render() (Line: 22)
Drupal\Core\Entity\Controller\EntityListController->listing('migration')
call_user_func_array(Array, Array) (Line: 123)
...
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

I had a similar issue. As result, migrate_plus version was out of date. The upgrade to the latest version (4.0.0-beta3) solved the issue

migrate_tools - 4.0.0-rc1

I need more help on reproducing this. Is it that an update solves things and time has passed enough that this is no longer an issue?

I get this after setting a migration status to false and importing config.
status: false
Setting it back to false and importing causes the error to go away.

$migration = $this->migrationPluginManager->createInstance($migration_entity->id());
sets $migration to false. We need to return NULL there. I'll make a patch.

Fix comment number.

+++ b/src/Controller/MigrationListBuilder.php
@@ -142,6 +142,9 @@ class MigrationListBuilder extends ConfigEntityListBuilder implements EntityHand
+        return NULL;

We don't need to return NULL explicitly. That is the default if we just return;.

However, I'd also like to see some tests of this. This should be possible by just tweaking and copy/pasting some of the existing ones. See MigrateExecutionFormTest as an example.

I've updated the patch with simplified return statement, gonna try to figure out some tests soon

Allright, attached two patches:

First is test only containing new test with following bits and pieces:

• Create new configs in migrate_tools_test submodule:
• migrate_plus.migrate_group.disabled - provides separete migration group to test disabled groups and avoid conflicts with existing default group
• migrate_plus.migration.fruit_terms_disabled - a clone of fruit_terms migration with status set to false, assigned to disabled group
• Provide MigrateListBuilderTest class with following tests:
• Visit list of migrations in default group, here everything should be fine
• Visit list of migrations in disabled group, here we should be able reproduce an error

Second patch contains new tests + fix for the error.

Expected result of test-only patch:

html/docroot$ ../vendor/bin/phpunit -c core/ --filter=MigrateListBuilderTest
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

Testing 
.E                                                                  2 / 2 (100%)

Time: 42.54 seconds, Memory: 1.30 GB

There was 1 error:

1) Drupal\Tests\migrate_tools\Functional\MigrateListBuilderTest::testMigrateListBuilderDisabled
Exception: Error: Call to a member function id() on bool
Drupal\migrate_tools\Controller\MigrationListBuilder->buildRow()() (Line: 150)


/var/www/html/docroot/core/lib/Drupal/Core/Test/HttpClientMiddleware/TestHttpClientMiddleware.php:51
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:203
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:156
/var/www/html/vendor/guzzlehttp/promises/src/TaskQueue.php:47
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:246
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:223
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:267
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:225
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:62
/var/www/html/vendor/guzzlehttp/guzzle/src/Client.php:182
/var/www/html/vendor/fabpot/goutte/Goutte/Client.php:180
/var/www/html/vendor/symfony/browser-kit/Client.php:318
/var/www/html/vendor/behat/mink-browserkit-driver/src/BrowserKitDriver.php:145
/var/www/html/vendor/behat/mink/src/Session.php:148
/var/www/html/docroot/core/tests/Drupal/Tests/UiHelperTrait.php:326
/var/www/html/docroot/modules/contrib/migrate_tools/tests/src/Functional/MigrateListBuilderTest.php:46

ERRORS!
Tests: 2, Assertions: 9, Errors: 1.

Expected result of test+fix patch:

html/docroot$ ../vendor/bin/phpunit -c core/ --filter=MigrateListBuilderTest
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

Testing 
..                                                                  2 / 2 (100%)

Time: 39.62 seconds, Memory: 1.30 GB

OK (2 tests, 10 assertions)

so test went as expected, but oh my, now I have to figure out how to copy it into drupalspoons gitlab thingy :o

Just ran into a similar Problem "Call to a member function id() on bool in Drupal\migrate_tools\Controller\MigrationListBuilder->buildRow()", the patch from @sandboxpl fixed it though!

Also the code example for the hook_migration_plugins_alter is not working with migrate_tools enabled: https://api.drupal.org/api/drupal/core%21modules%21migrate%21migrate.api...

Thx everyone!

Patch #20 works perfectly!

Confirming RTBC! :) Removing needs-tests as they are present now as of #20.

Thanks for the contributions.