Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Patch attached changes "release/project_release.js" functions to be included with Drupal.behaviors and no more doc.ready logic. Untested, needs review.
Comment | File | Size | Author |
---|---|---|---|
#8 | D6_project_Drupal_behaviors_project_release_2009011301.patch | 975 bytes | hass |
Project_D6_project_releaseJS_1.patch | 888 bytes | hass |
Comments
Comment #1
hass CreditAttribution: hass commentedPatches apply are against aclight's SYN.
Comment #2
hass CreditAttribution: hass commentedComment #3
aclight CreditAttribution: aclight commentedAs per http://drupal.org/node/114774#javascript-behaviors I believe that something needs to be changed near where we use
.each
.The upgrade docs give the following example:
Old code:
New code:
Comment #4
hass CreditAttribution: hass commentedI've stolen this from OG... and therefore it seems to be ok. We are not using each in the old code and therefore we don't use it in new code...
Comment #5
hass CreditAttribution: hass commentedhttp://raincitystudios.com/blogs-and-pods/katherine-bailey/the-lowdown-j...
http://api.drupal.org/api/file/developer/topics/javascript_startup_guide...
Comment #6
hass CreditAttribution: hass commentedI've also checked the same change in Google Analytics 6.x-2.x and it seems working well.
Comment #7
dwwComment #8
hass CreditAttribution: hass commentedPatch against CVS without local windows paths for easier patching. No changes.
Comment #9
dwwCommitted #8 to HEAD since that part is fine and working. However, project_release.js does use .each(), and it seems like what aclight pointed out in #3 is still applicable.
Comment #10
hass CreditAttribution: hass commentedI've only upgraded the outdated
$(document).ready(Drupal.projectReleaseAutoAttach);
on doc ready to the new logic. As we are only changing one element we don't need to "each" something else... !?