There are some errors caused by a wrong array definition in PHP, like:

Warning: Illegal string offset 'rooms_children_discount_options' in UnitPricingCalendar->calculatePrice() (line 75 of .../rooms/modules/rooms_pricing/includes/rooms_pricing.unit_pricing_calendar.inc).
Notice: Array to string conversion in UnitPricingCalendar->calculatePrice() (line 75 of .../rooms/modules/rooms_pricing/includes/rooms_pricing.unit_pricing_calendar.inc).
Warning: Illegal string offset 'rooms_price_calculation' in UnitPricingCalendar->calculatePrice() (line 76 of .../rooms/modules/rooms_pricing/includes/rooms_pricing.unit_pricing_calendar.inc).
Warning: Illegal string offset 'pricing_events' in UnitPricingCalendar->calculatePrice() (line 79 of .../rooms/modules/rooms_pricing/includes/rooms_pricing.unit_pricing_calendar.inc).
Notice: Array to string conversion in UnitPricingCalendar->calculatePrice() (line 79 of .../rooms/modules/rooms_pricing/includes/rooms_pricing.unit_pricing_calendar.inc).

Those errors are caused because what is supposed to be an array is being declared as an empty string.

CommentFileSizeAuthor
#5 rooms-php_warning_illegal_string_offset_rooms_children_discount_options-2906888-5.patch624 bytesadci_contributor
#4 2906888-4-php-warning-illegal-string-offset-rooms_children_discount_options.patch635 bytesjuankvillegas
#2 2906888-1-php-arning-illegal-string-offset-rooms_children_discount_options.patch647 bytesjuankvillegas
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

juankvillegas created an issue. See original summary.

juankvillegas’s picture

juankvillegas CreditAttribution: juankvillegas commented
FileSize
2906888-1-php-arning-illegal-string-offset-rooms_children_discount_options.patch647 bytes
aken.niels@gmail.com’s picture

aken.niels@gmail.com
he/him
Primary language Dutch
CreditAttribution: aken.niels@gmail.com commented

Seems to do the trick, small note though, that this patch's root path is from outside the module folder.

juankvillegas’s picture

juankvillegas CreditAttribution: juankvillegas commented
FileSize
2906888-4-php-warning-illegal-string-offset-rooms_children_discount_options.patch635 bytes

Here is a fixed patch from module's folder.

adci_contributor’s picture

adci_contributor CreditAttribution: adci_contributor at ADCI Solutions commented
FileSize
rooms-php_warning_illegal_string_offset_rooms_children_discount_options-2906888-5.patch624 bytes

Your patch still isn't appliable neither through 'patch -p1' nor 'drush make'. Here is the right one.

Skin’s picture

Skin
Primary language Italian
Location Italy
CreditAttribution: Skin commented

On my fresh Rooms installation with php 7.2 is working for me, may be someone can test and commit?

Sherydan’s picture

Sherydan CreditAttribution: Sherydan commented

Have a fresh D7 rooms too, #5 worked for me. Agree with @Skin, I guess someone got to commit that.

ducdebreme’s picture

ducdebreme CreditAttribution: ducdebreme commented

I think, it is worth explicitly mentioning that this is a bug, which only occurs with PHP 7.2 and above.
I tracked it down myself and afterwards discovered it in the issue queue.

  • nicola85 committed fea2205 on 7.x-1.x 
    Issue #2906888 by juankvillegas: PHP Warning: Illegal string offset '...

acrollet credited nicola85.

acrollet’s picture

acrollet CreditAttribution: acrollet commented
Status: Active » Fixed

Committed, thanks for the report and the patch

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.