Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
It seems that after the latest changes (including a patch I provided) there's still a warning being triggered under some circumstances.
The error seen is:
reset() expects parameter 1 to be array, null given at FirebaseNotificationsService, line 315
The solution is trivial and I've attached a patch for it. Tested it locally and I don't see any other errors.
Comment | File | Size | Author |
---|---|---|---|
#5 | fixed-reset-notice-2925480-5.patch | 576 bytes | japicoder |
#4 | fixed-results-property-notice-2924381-4.patch | 576 bytes | japicoder |
#2 | fixed-reset-notice-2925480-2.patch | 543 bytes | japicoder |
Comments
Comment #2
japicoder CreditAttribution: japicoder at Cocomore AG commentedAdded patch
Comment #3
japicoder CreditAttribution: japicoder at Cocomore AG commentedComment #4
japicoder CreditAttribution: japicoder at Cocomore AG commentedI've found that depending on the "to" parameter, Firebase returns a different response.
According to the documentation at https://firebase.google.com/docs/cloud-messaging/send-message, if the notification is sent using an app register token, the response will be:
But if the notification is sent to a topic, the response will be:
Then, here's a new version of the patch to check for notification failures.
Comment #5
japicoder CreditAttribution: japicoder at Cocomore AG commentedUploaded the patch with a wrong name. Here is the correct one
Comment #7
leopaccanaro CreditAttribution: leopaccanaro at CI&T commentedComment #8
leopaccanaro CreditAttribution: leopaccanaro at CI&T commentedComment #9
leopaccanaro CreditAttribution: leopaccanaro at CI&T commented