Everytime I change something in the slideshow or refresh the cache, I get an error notification (in the red):
Notice: Undefined index: views_slideshow_pager_bullets in template_preprocess_views_slideshow_pager_bullets() (line 295 of modules/contrib/views_slideshow/views_slideshow.theme.inc).
It continues (in the white):
template_preprocess_views_slideshow_pager_bullets(Array, 'views_slideshow_pager_bullets', Array) (Line: 287)
Drupal\Core\Theme\ThemeManager->render('views_slideshow_pager_bullets', Array) (Line: 437)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 195)
Drupal\Core\Render\Renderer->render(Array) (Line: 221)
template_preprocess_views_slideshow_pager_widget_render(Array, 'views_slideshow_pager_widget_render', Array) (Line: 287)
Drupal\Core\Theme\ThemeManager->render('views_slideshow_pager_widget_render', Array) (Line: 437)
Drupal\Core\Render\Renderer->doRender(Array) (Line: 450)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 195)
Drupal\Core\Render\Renderer->render(Array) (Line: 490)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 74) etc.
Seems to have to do with the new bullets, that I use. I use the bootstrap theme together with a child theme.
The error message disappears after reload and everything seems to work fine.
Drupal Settings:
<script type="application/json" data-drupal-selector="drupal-settings-json">{"path":{"baseUrl":"\/","scriptPath":null,"pathPrefix":"","currentPath":"node\/2","currentPathIsAdmin":false,"isFront":true,"currentLanguage":"de"},"pluralDelimiter":"\u0003","ajaxPageState":{"libraries":"admin_toolbar\/toolbar.tree,admin_toolbar_tools\/toolbar.icon,bootstrap\/popover,bootstrap\/tooltip,coffee\/drupal.coffee,contextual\/drupal.contextual-links,contextual\/drupal.contextual-toolbar,core\/drupal.active-link,core\/html5shiv,devel\/devel-toolbar,history\/mark-as-read,quickedit\/quickedit,mytheme\/global-styling,shortcut\/drupal.shortcut,statistics\/drupal.statistics,system\/base,toolbar\/toolbar,toolbar\/toolbar.escapeAdmin,user\/drupal.user.icons,views\/views.module,views_slideshow\/jquery_hoverIntent,views_slideshow\/pager_bullets,views_slideshow\/widget_info,views_slideshow_cycle\/jquery_cycle,views_slideshow_cycle\/json2,views_slideshow_cycle\/views_slideshow_cycle","theme":"mytheme","theme_token":null},"ajaxTrustedUrl":{"\/suche":true},"coffee":{"maxResults":7},"bootstrap":{"forms_has_error_value_toggle":1,"modal_animation":1,"modal_backdrop":"true","modal_keyboard":1,"modal_show":1,"modal_size":"","popover_enabled":1,"popover_animation":1,"popover_container":"body","popover_content":"","popover_delay":"0","popover_html":0,"popover_placement":"right","popover_selector":"","popover_title":"","popover_trigger":"click","popover_trigger_autoclose":1,"tooltip_enabled":1,"tooltip_animation":1,"tooltip_container":"body","tooltip_delay":"0","tooltip_html":0,"tooltip_placement":"auto left","tooltip_selector":"","tooltip_trigger":"hover"},"statistics":{"data":{"nid":"2"},"url":"\/core\/modules\/statistics\/statistics.php"},"history":{"nodesToMarkAsRead":{"2":true}},"toolbar":{"breakpoints":{"toolbar.narrow":"only screen and (min-width: 16.5em)","toolbar.standard":"only screen and (min-width: 38.125em)","toolbar.wide":"only screen and (min-width: 61em)"},"subtreesHash":"AQdcDapCrtA2-48Urrd7f-mBjjxNO2G591jNkUIu2ig"},"viewsSlideshowPagerFields":{"slider_frontpage-slider_frontpage":{"bottom":{"activatePauseOnHover":null}}},"viewsSlideshowPager":{"slider_frontpage-slider_frontpage":{"bottom":{"type":"viewsSlideshowPagerBullets"}}},"viewsSlideshowCycle":{"#views_slideshow_cycle_main_slider_frontpage-slider_frontpage":{"num_divs":5,"id_prefix":"#views_slideshow_cycle_main_","div_prefix":"#views_slideshow_cycle_div_","vss_id":"slider_frontpage-slider_frontpage","effect":"fade","transition_advanced":0,"timeout":5000,"speed":700,"delay":0,"sync":1,"random":0,"pause":1,"pause_on_click":0,"action_advanced":0,"start_paused":0,"remember_slide":0,"remember_slide_days":1,"pause_in_middle":0,"pause_when_hidden":0,"pause_when_hidden_type":"full","amount_allowed_visible":"","nowrap":0,"fixed_height":1,"items_per_slide":1,"items_per_slide_first":0,"items_per_slide_first_number":1,"wait_for_image_load":1,"wait_for_image_load_timeout":3000,"cleartype":0,"cleartypenobg":0,"advanced_options":"{\u0022timeout\u0022:\u002215000\u0022}","advanced_options_choices":0,"advanced_options_entry":""}},"viewsSlideshow":{"slider_frontpage-slider_frontpage":{"methods":{"goToSlide":["viewsSlideshowSlideCounter","viewsSlideshowPager","viewsSlideshowCycle"],"nextSlide":["viewsSlideshowSlideCounter","viewsSlideshowPager","viewsSlideshowCycle"],"pause":["viewsSlideshowControls","viewsSlideshowCycle"],"play":["viewsSlideshowControls","viewsSlideshowCycle"],"previousSlide":["viewsSlideshowSlideCounter","viewsSlideshowPager","viewsSlideshowCycle"],"transitionBegin":["viewsSlideshowSlideCounter","viewsSlideshowPager"],"transitionEnd":[]},"paused":0}},"user":{"uid":"1232","permissionsHash":"8d194d7962a38659010be142a0b998fac83f6914ffc85bf390d988dfce0785b0"}}
Comment | File | Size | Author |
---|---|---|---|
#20 | views_slideshow-fix_bullets_hover-2926311-20.patch | 2.24 KB | sitiveni |
#16 | views_slideshow_fix_bullets_hover-2926311-16.patch | 1.41 KB | gtucker6 |
| |||
#15 | views_slideshow_fix_bullets_hover-2926311-15.patch | 1.46 KB | sakiland |
#13 | 2926311-13.patch | 640 bytes | israelshmueli |
| |||
#8 | 2926311-8.patch | 1.44 KB | h3rj4n |
Comments
Comment #2
tibezh CreditAttribution: tibezh at OPTASY, Drupal Ukraine Community commentedI have some problems.
Here is a patch for fix problem. Patch add an option "Activate Slide on Pager Hover" + fix notice.
After apply patch need resave a style plugin settings.
Comment #3
tibezh CreditAttribution: tibezh at OPTASY, Drupal Ukraine Community commentedComment #4
iryston CreditAttribution: iryston as a volunteer commentedThanks, Ivan!
#2 works for me.
Comment #5
kmajzlik CreditAttribution: kmajzlik at Ciklum Western Europe commentedComment #6
kmajzlik CreditAttribution: kmajzlik at Ciklum Western Europe commentedComment #7
andrezstar CreditAttribution: andrezstar commentedI still have the prob after applying the patch.
It only disappears if i desactivate the option "pause on hover" of the viewslideshow options
Comment #8
h3rj4n CreditAttribution: h3rj4n as a volunteer commentedThe patch from #2 did not work for me. Changed some names and the following patch worked for me (running version 4.6).
Comment #9
pbosmans CreditAttribution: pbosmans as a volunteer and at UC Leuven-Limburg commentedWith patch #8 the undefined index notice is gone but when a new notice appears when i go into the slideshow view-settings :
Notice: Array to string conversion in Drupal\Core\Render\Element\Checkbox::processCheckbox() (line 129 of \core\lib\Drupal\Core\Render\Element\Checkbox.php).
Comment #10
richgerdesPatch in #8 works for me. I don't receive any errors as mention in #9. Marking RTBC.
Comment #11
richgerdesComment #12
StepanISK CreditAttribution: StepanISK commentedThanks, h3rj4n!
#8 works for me.
Comment #13
israelshmueli CreditAttribution: israelshmueli as a volunteer and at Bar-Ilan University commentedStill getting the notice message even after applying the patch/es.
seems to work at first but a message shows up again after changed and saved slideshow settings.
Message stopped after I went to that line 295 and set
intead of
I am enclosing this unsatisfying solution as a patch.
Comment #14
israelshmueli CreditAttribution: israelshmueli as a volunteer and at Bar-Ilan University commentedComment #15
sakiland CreditAttribution: sakiland as a volunteer commented@israelshmueli is right, patch is not complete. There is some typo in it. Variable name should be views_slideshow_pager_bullets_hover, not views_slideshow_pager_bullets.
views_slideshow_pager_bullets is id of ViewsSlideshowWidget plugin
Here corrected patch.
Comment #16
gtucker6 CreditAttribution: gtucker6 as a volunteer commentedI used @sakiland's code to create a new patch with a test. This is working for me with no errors currently.
Comment #17
g089h515r806 CreditAttribution: g089h515r806 commentedApply patch 16 and
change the code
from
'activatePauseOnHover' => $vars['settings']['views_slideshow_pager_bullets']['views_slideshow_pager_bullets_hover'],
to :
'activatePauseOnHover' => isset($vars['settings']['views_slideshow_pager_bullets']['views_slideshow_pager_bullets_hover']) ? $vars['settings']['views_slideshow_pager_bullets']['views_slideshow_pager_bullets_hover'] : '',
fix this issue.
Comment #18
xaver CreditAttribution: xaver as a volunteer commentedUnfortunately doesen't work for me,
I've applied patch 16
Drupal version : 8.6.1
Drupal bootstrap : Successful
PHP binary : /usr/bin/php7.1
Notice: Undefined index: views_slideshow_pager_bullets in template_preprocess_views_slideshow_pager_bullets() (line 295 of modules/contrib/views_slideshow/views_slideshow.theme.inc).
template_preprocess_views_slideshow_pager_bullets(Array, 'views_slideshow_pager_bullets', Array) (Line: 287)
Drupal\Core\Theme\ThemeManager->render('views_slideshow_pager_bullets', Array) (Line: 437)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 195)
Drupal\Core\Render\Renderer->render(Array) (Line: 221)
template_preprocess_views_slideshow_pager_widget_render(Array, 'views_slideshow_pager_widget_render', Array) (Line: 287)
Drupal\Core\Theme\ThemeManager->render('views_slideshow_pager_widget_render', Array) (Line: 437)
Drupal\Core\Render\Renderer->doRender(Array) (Line: 450)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 195)
Drupal\Core\Render\Renderer->render(Array) (Line: 490)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 77)
__TwigTemplate_f54b7c1e2bbeec00da4446a08b1c899baf1e0440a8b84f71fde8dfb3ee774c78->doDisplay(Array, Array) (Line: 432)
Twig_Template->displayWithErrorHandling(Array, Array) (Line: 403)
Twig_Template->display(Array) (Line: 411)
Twig_Template->render(Array) (Line: 64)
twig_render_template('modules/contrib/views_slideshow/templates/views-view-slideshow.html.twig', Array) (Line: 384)
Drupal\Core\Theme\ThemeManager->render('views_view_slideshow', Array) (Line: 437)
Drupal\Core\Render\Renderer->doRender(Array) (Line: 450)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 195)
Drupal\Core\Render\Renderer->render(Array) (Line: 490)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 117)
__TwigTemplate_532bd15a1ee96b91d410ad8b8f05717c156aa86733c3c964a524ef7b00f7f6db->doDisplay(Array, Array) (Line: 432)
Twig_Template->displayWithErrorHandling(Array, Array) (Line: 403)
Twig_Template->display(Array) (Line: 411)
Twig_Template->render(Array) (Line: 64)
twig_render_template('themes/contrib/bootstrap/templates/views/views-view.html.twig', Array) (Line: 384)
Drupal\Core\Theme\ThemeManager->render('views_view', Array) (Line: 437)
Drupal\Core\Render\Renderer->doRender(Array) (Line: 450)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 195)
Drupal\Core\Render\Renderer->render(Array, ) (Line: 226)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 582)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 227)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 117)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object) (Line: 76)
Drupal\webprofiler\EventDispatcher\TraceableEventDispatcher->dispatch('kernel.view', Object) (Line: 156)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 38)
Drupal\webprofiler\StackMiddleware\WebprofilerMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 665)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
Comment #19
dwwThanks everyone for your work in here!
Patches #15 and #16 are nearly identical files, with no visible interdiff.
@Gtucker6: If there was supposed to be a test with #16, it wasn't added to the git command that generated the patch file. Please consider re-uploading (ideally with first a test-only patch, and then a full patch with the fix).
@g089h515r806: Please upload #17 as a patch if possible.
@xaver re: #18: You still have to visit each view and re-save the settings for the fix to go into effect.
Which brings me to: we probably need an update function that adds the missing setting to existing views using a slideshow display. :/ That's rarely fun, but perhaps needed before this is RTBC.
Otherwise, we at least need the fix from #17 as a working patch, since #15/#16 still depend on re-saving each view to stop generating errors.
Thanks,
-Derek
Comment #20
sitiveni CreditAttribution: sitiveni commentedCombined #16 + #17 into one patch.
It did resolve my issue. Thanks to all.
Comment #21
Ollie222 CreditAttribution: Ollie222 commentedThe patch in #20 applied to the latest dev version looks to have fixed the warnings for me too.
Comment #22
ivnish CreditAttribution: ivnish commented#20 works for me! Thanks!
Comment #23
DD 85 CreditAttribution: DD 85 commented#20 works for me! Thanks!
Comment #24
DrupalDope CreditAttribution: DrupalDope commentedthanks, #20 worked for me as well
Comment #25
ivnish CreditAttribution: ivnish commentedComment #26
Dinesh18 CreditAttribution: Dinesh18 at Singapore Press Holdings commented#20 works perfectly fine. +1 to RTBC
Comment #27
Anatoliy Vorobyov CreditAttribution: Anatoliy Vorobyov at FFW commented#20 worked for me!
Comment #29
NickDickinsonWildeApplied - with a minor change. using `??` instead of the `isset($value) $value : $alt` pattern.
Thanks y'all
Comment #31
Erso CreditAttribution: Erso commented#20 worked for me after
-Save without bullet
-Save with bullet
-Clear
Comment #32
ressa CreditAttribution: ressa at Ardea commentedThanks for fixing this. Since the last release was November 2017 is it worth considering a fresh release, so everyone can make good use of this improvement?
Comment #33
DD 85 CreditAttribution: DD 85 commentedYes
Comment #34
Matt BThis is not fixed - I still get the issue and I'm on the latest version of this module and drupal. Please re-open the issue, fix and create a new module release.
Comment #35
ivnish CreditAttribution: ivnish commentedMatt, this was fixed in the dev version. But last release version at 2017. Needs create new stable release
Comment #36
Matt BNeeds to stay open as a bug against the latest stable version then. When will a new stable version be released? I don't want to run dev code if I can possible avoid it.
Comment #37
ivnish CreditAttribution: ivnish commentedNo. Bug was fixed. Needs wait while project maintainer create new stable release. You can try to contact with maintainer using contact form in the user profile
Comment #38
ressa CreditAttribution: ressa at Ardea commentedJust a tip: If you use the Bootstrap theme and can't wait for a new release, you can also make a carousel with Views Bootstrap.
Comment #39
osopolarFixed in release 8.x-4.7.