[D7] Content cancel button

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/project/projectapplications/issues/2926769

Project 2: https://www.drupal.org/project/projectapplications/issues/2926194

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi @gaurav_drupal,

• Firstly you need to add hook_help
• You could optimized your no of lines of code in your module
  

      if (!empty($form['#node'])) {
      if (!empty($form['#node']->nid)) {
        $nid = $form['#node']->nid;
        $node = node_load($nid);
        $node_uri = node_uri($node);
        $fallback_destinaton = $node_uri['path'];
      }
    }
   

  in these three lines

    if (isset($form['#node']) && !empty($form['#node']->nid)) {
        $fallback_destinaton = 'node/'.$form['#node']->nid;
    }
  

Regards
Satyam

If you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.

Hi @Gaurav_drupal,

Please find the below review comments.

Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
The REQUIREMENTS section is missing.
The CONFIGURATION section is missing.

Hi Gaurav_drupal,

Thank you for contribution!

Review of the 7.x-1.x branch (commit 2596154): I checked this module and it looks good to me.

Thanks,
Shakti

This module is too short to give you the security coverage role, but we can manually opt into security coverage for you. I also looked at your check_dns module, but that is also very short and uses check_plain() wrong (check_plain() should only be used on output when something is printed to HTML). Please open a new issue once you have another project to opt into security coverage.

Thanks for your contribution, Gaurav!

I opted into security coverage for your project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.