That will teach you to provide a nice simple but useful module.
I do hope one day to get to D6 so will need it :)

CommentFileSizeAuthor
#6 d6_port.patch16.99 KBIsland Usurper
#3 d6_port.patch16.99 KBIsland Usurper
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rszrama’s picture

Status: Active » Postponed

lol I'm sure it won't be that hard... I've gotten quite used to the process updating Ubercart. ; )

Will postpone while I nail down a couple more administrative features, but I'll get it to D6 as soon as I can.

Anonymous’s picture

No rush As long as its ready by the time D8 is released I'll be happy, all the other modules I use should be up to D6 by then too, i hope:)

Island Usurper’s picture

Status: Postponed » Needs review
FileSize
16.99 KB

Happy day, patch is here. Drupalcon is a good place to do work. :D

chasz’s picture

+1

Jeremy Toaster’s picture

How do we apply this patch?
Do I install the 5.x version first, then edit the .module file and replace the code with this?

Any help would be great!

jeremy

Island Usurper’s picture

FileSize
16.99 KB

This patch affects the .info, .install, and the .module files. The easiest thing would be to use the Linux patch program on the Drupal 5.x version.

I noticed there was a problem in hook_uninstall(). It would have tried to install the database tables again. Rerolled the patch.

Flying Drupalist’s picture

Subscribing, will try patch. Hopefully someone will commit :)

Flying Drupalist’s picture

*delete, doublepost

Edit: It works as expected. Great patch.

Anonymous’s picture

Have installed the patch - seems to work so far

Anonymous’s picture

As far as i can tell the patch works fine, maybe with a couple more response it can be commited?

somenoise’s picture

Would be great to see it commited

Anonymous’s picture

Have now been using for a month with no apparent issues

momper’s picture

everything looks fine - will there be an official dev version?

thanks momper

FWE’s picture

Subscribing...

sbydrupal’s picture

I am trying to apply the above patches (tried both #3 and #6 patches above to 5.x-1.x-dev), got the
results below:

----------------------------------------------------------------------------------------
patch < d6_port.patch
patching file keyword_autocomplete.info
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file keyword_autocomplete.info.rej
patching file keyword_autocomplete.install
patching file keyword_autocomplete.module
-----------------------------------------------------------------------------------------

I placed the patch to the same directory as keyword_autocomplete, and give the patch command.

Is there anything I am doing wrong here ????

Thanks

Anonymous’s picture

OK
No idea whet your doing putting it in the directory and what this patch command you run was.

But I applied the patch manually myself a long time ago November, and that method does work/ It only takes a coule of minutes so may be worth a try

sbydrupal’s picture

Thanks Midkemia, I edited by hand and it works now!!!

One question is about overall usability related. There is a related module "Search Autocomplete".
It seems to be no activity for quite long time. It seems from possible functionality options, from suggestions to sorting..., Search Autocomplete seems to be quite a hard task to get it right and useful.
Is this the reason there is no activity so far in Drupal about search autocomplete ? We see this functionality in large number of sites. Is it too much of a task to merge this functionality with Keyword Autocomplete ? From usability perspective, would Keyword Autocomplete be even better than Search Autocomplete after certain period of user entries are collected, as these will be real search keywords entered by real users, instead of a search algorithm trying to predict which combination of keywords should be presented in which sorting order.

If you can confirm this, then Keyword Autocomplete might be the best way to go.

Thanks

Island Usurper’s picture

If you are running the patch from the keyword_autocomplete directory, you need to tell it to remove the CVS path information first:

patch -p5 < d6_port.patch

This tells it to look for keyword_autocomplete.info (.module, etc.) in the current directory instead of /cvs/drupal-contrib/contributions/modules/keyword_autocomplete, which probably doesn't exist on your machine.

rszrama’s picture

Status: Needs review » Fixed

So, the patch actually needed a little bit of work to add an update function. I'm guessing no one's really tried to patch/update from D5 but has just installed this on new D6 installs. : ?

In any event, I got this taken care of real quick... puttin' it up as a beta until someone else verifies it's workin'.

Anonymous’s picture

I went from 5 to 6, but as i was used to tweaking info files at the time, I cant remember if anything was done to it

Anonymous’s picture

OK I have just installed the Official Beta and Run Update on the patched version. All appears to be working so far

momper’s picture

Title: Update to D6 » Keyword Autocomplete: Update to D6

for better tracking

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.