Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
After running coder, there are a few coding standard issues:
FILE: .../modules/contrib/web_accessibility/web_accessibility.routing.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
15 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: .../web/modules/contrib/web_accessibility/web_accessibility.install
----------------------------------------------------------------------
FOUND 12 ERRORS AND 1 WARNING AFFECTING 13 LINES
----------------------------------------------------------------------
53 | ERROR | [x] Expected 1 space after closing parenthesis; found
| | 0
59 | ERROR | [x] Doc comment short description must end with a
| | full stop
61 | ERROR | [ ] Description for the @return value is missing
63 | ERROR | [x] Expected 1 space before opening brace; found 0
64 | ERROR | [x] Inline comments must start with a capital letter
65 | ERROR | [x] Short array syntax must be used to define arrays
72 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: ]
79 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements
80 | ERROR | [x] Short array syntax must be used to define arrays
82 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements
83 | ERROR | [x] Short array syntax must be used to define arrays
86 | ERROR | [x] Short array syntax must be used to define arrays
93 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...al8/web/modules/contrib/web_accessibility/src/Form/AdminForm.php
----------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one
| | blank line
2 | ERROR | [x] Namespaced classes, interfaces and traits should
| | not begin with a file doc comment
20 | ERROR | [ ] Missing short description in doc comment
28 | ERROR | [ ] Missing parameter comment
46 | ERROR | [ ] Public method name "AdminForm::getFormID" is not in
| | lowerCamel format
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...modules/contrib/web_accessibility/src/Form/DeleteServiceForm.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------
78 | ERROR | Parameter $form is not described in comment
78 | ERROR | Parameter $form_state is not described in comment
----------------------------------------------------------------------
FILE: .../web/modules/contrib/web_accessibility/src/WebServiceManager.php
----------------------------------------------------------------------
FOUND 8 ERRORS AND 4 WARNINGS AFFECTING 10 LINES
----------------------------------------------------------------------
13 | ERROR | [x] Function comment short description must start
| | with exactly one space
13 | ERROR | [x] Doc comment short description must end with a
| | full stop
19 | ERROR | [x] Doc comment short description must be on the
| | first line
19 | ERROR | [x] Doc comment short description must end with a
| | full stop
26 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: URL_TOKEN
30 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: URL_TOKEN
34 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: URL_TOKEN
35 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: ]
48 | ERROR | [ ] Missing parameter comment
50 | ERROR | [x] Additional blank lines found at end of doc
| | comment
55 | ERROR | [ ] Missing short description in doc comment
56 | ERROR | [ ] Description for the @return value is missing
----------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...eb/modules/contrib/web_accessibility/src/WebServiceInterface.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
18 | ERROR | Parameter $name is not described in comment
----------------------------------------------------------------------
FILE: ...8/web/modules/contrib/web_accessibility/web_accessibility.module
----------------------------------------------------------------------
FOUND 5 ERRORS AND 4 WARNINGS AFFECTING 7 LINES
----------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
12 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
30 | WARNING | [ ] Line exceeds 80 characters; contains 114
| | characters
30 | WARNING | [x] There must be no blank line following an inline
| | comment
30 | ERROR | [x] No space found before comment text; expected "//
| | $nodeUrl =
| | Url::fromRoute('entity.node.canonical', ['node'
| | => $node->id()], ['absolute' =>
| | TRUE])->toString();" but found "//$nodeUrl =
| | Url::fromRoute('entity.node.canonical', ['node'
| | => $node->id()], ['absolute' =>
| | TRUE])->toString();"
38 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements
40 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: ]
43 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: '</div>'
46 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...web/modules/contrib/web_accessibility/web_accessibility.info.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
5 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Time: 95ms; Memory: 6Mb
Comment | File | Size | Author |
---|---|---|---|
#3 | fixed_coding_standard_errors-2947913-3.patch | 10.93 KB | Deepthi kumari |
Comments
Comment #2
Deepthi kumari CreditAttribution: Deepthi kumari at TA Digital commentedComment #3
Deepthi kumari CreditAttribution: Deepthi kumari at TA Digital commentedHi,
Applied the patch. please review.
Comment #5
cmd87 CreditAttribution: cmd87 at 1xINTERNET commentedCommitted https://cgit.drupalcode.org/web_accessibility/commit/?id=9a2f240 and pushed to 8.x-1.x
Thanks!
Comment #6
cmd87 CreditAttribution: cmd87 at 1xINTERNET commentedComment #7
cmd87 CreditAttribution: cmd87 at 1xINTERNET commented