Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
After running coder for Drupal best practices, I found the following issues:
FILE: ...al8/web/modules/contrib/web_accessibility/src/Form/AdminForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
55 | WARNING | t() calls should be avoided in classes, use
| | dependency injection and $this->t() instead
----------------------------------------------------------------------
FILE: ...8/web/modules/contrib/web_accessibility/web_accessibility.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
30 | WARNING | There must be no blank line following an inline
| | comment
----------------------------------------------------------------------
Time: 34ms; Memory: 4Mb
Comment | File | Size | Author |
---|---|---|---|
#10 | interdiff.txt | 536 bytes | ankitjain28may |
#10 | best-practices-2947918-10.patch | 3.77 KB | ankitjain28may |
#8 | best-practices-2947918-7.patch | 3.76 KB | pvsureshmca |
Comments
Comment #3
cmd87 CreditAttribution: cmd87 at 1xINTERNET commentedI've fixed Drupal BestPractices issues for files listed in description, but there is still some issues with this on README.md file, see here https://pareview.sh/pareview/https-git.drupal.org-project-web_accessibil...
@rteijeiro Please provide a patch to fix this.
Comment #4
cmd87 CreditAttribution: cmd87 at 1xINTERNET commentedComment #5
rteijeiro CreditAttribution: rteijeiro at 1xINTERNET commentedThanks for the review @cmd87!
Unassigning to let someone else to provide the patch. It's a good issue for a novice contributor ;)
Comment #6
pvsureshmca CreditAttribution: pvsureshmca at Drupal Partners commentedComment #7
pvsureshmca CreditAttribution: pvsureshmca at Drupal Partners commentedI have found below list of coding standard issue in the last run.
Comment #8
pvsureshmca CreditAttribution: pvsureshmca at Drupal Partners commentedHi,
Please verify the attached patch for above listed best practice issue.
Thank you.
Comment #9
ankitjain28may CreditAttribution: ankitjain28may as a volunteer and at Google Summer of Code commentedThere is one more concat operator in this file which need to be fixed too.
Comment #10
ankitjain28may CreditAttribution: ankitjain28may as a volunteer and at Google Summer of Code commentedInterdiff and patch for the above issue.
Comment #11
pvsureshmca CreditAttribution: pvsureshmca at Drupal Partners commentedHi,
The above patch seems to be working fine for me.
Comment #13
cmd87 CreditAttribution: cmd87 at 1xINTERNET commentedCommited and pushed to 8.x-1.x.
Thanks!
Comment #14
cmd87 CreditAttribution: cmd87 at 1xINTERNET commentedComment #15
cmd87 CreditAttribution: cmd87 at 1xINTERNET commented