When you first install the module, there is no default value set on notification type(both radios are unchecked), so if you don't select any radios an error appears.See screenshots for more information.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nkoporec created an issue. See original summary.

nkoporec’s picture

Status: Active » Needs review
FileSize
890 bytes

Created a patch to fix this bug, please review it.

krina.addweb’s picture

FileSize
18.12 KB

@nkoporec, Thanks for the patch, your patch works well for me as required. I verify it & attached the screenshots for the same.

bhanuprakashnani’s picture

Status: Needs review » Reviewed & tested by the community

Gone through the changes. Changes made are fine. Patch applies cleanly.

alesbencina’s picture

Tested on Drupal 8.4. Patch applies ok and it's working.

vdenis’s picture

Tested as well on Drupal 8.4.0 and can confirm that patch works as described.

devbanana’s picture

Patch also applies for me. Any reason it's not committed and released yet?

  • greggles committed 28b2e29 on 8.x-1.x authored by nkoporec
    Issue #2951094 by nkoporec, krina.addweb: No default value set
    
greggles’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for all the feedback and reviews. Now committed/pushed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tulvit’s picture

Quite a funny situation.

I've experienced the same issue with 8.x-1.0-beta7 (Drupal is 8.7.7), and I've fixed it with a patch which reverts back changes from the previous already approved and committed patch.

UPDATE
Latest version 8.x-1.0 with Drupal 8.7.8 - same issue, same fix.