Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
When you first install the module, there is no default value set on notification type(both radios are unchecked), so if you don't select any radios an error appears.See screenshots for more information.
Comment | File | Size | Author |
---|---|---|---|
#11 | comment_notify.patch | 615 bytes | tulvit |
#11 | screenshot_unchecked_radiobuttons.png | 34.99 KB | tulvit |
#6 | Screen Shot 2018-05-30 at 10.55.36.png | 86.07 KB | vdenis |
#3 | comment.png | 18.12 KB | krina.addweb |
#2 | comment_notify_default_value_2951094_2.patch | 890 bytes | nkoporec |
|
Comments
Comment #2
nkoporecCreated a patch to fix this bug, please review it.
Comment #3
krina.addweb CreditAttribution: krina.addweb at AddWeb Solution Pvt. Ltd. commented@nkoporec, Thanks for the patch, your patch works well for me as required. I verify it & attached the screenshots for the same.
Comment #4
bhanuprakashnani CreditAttribution: bhanuprakashnani at Google Summer of Code commentedGone through the changes. Changes made are fine. Patch applies cleanly.
Comment #5
alesbencina CreditAttribution: alesbencina at Agiledrop - Your Trusted Drupal Teammates commentedTested on Drupal 8.4. Patch applies ok and it's working.
Comment #6
vdenis CreditAttribution: vdenis at Agiledrop - Your Trusted Drupal Teammates commentedTested as well on Drupal 8.4.0 and can confirm that patch works as described.
Comment #7
devbanana CreditAttribution: devbanana as a volunteer commentedPatch also applies for me. Any reason it's not committed and released yet?
Comment #9
gregglesThanks for all the feedback and reviews. Now committed/pushed.
Comment #11
tulvit CreditAttribution: tulvit as a volunteer commentedQuite a funny situation.
I've experienced the same issue with 8.x-1.0-beta7 (Drupal is 8.7.7), and I've fixed it with a patch which reverts back changes from the previous already approved and committed patch.
UPDATE
Latest version 8.x-1.0 with Drupal 8.7.8 - same issue, same fix.