Well, didn't like the 'older polls' link and removed it, also added sorting the results.. but only as a quick hack.
Now today i finished this patch, i'm not totally sure about all strings and about the poll_update_7000 naming so comments appreciated. It's running live without PHP errors on hfopi.org at least.

CommentFileSizeAuthor
#7 issue-295958-7.patch7.88 KBlilou
#4 poll-module-add-sorting-and-link-visibility-options.patch7.25 KBeMPee584
poll-module-add-options.patch5.8 KBeMPee584
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lilou’s picture

lilou CreditAttribution: lilou commented
Title: PATCH: add options to hide 'older polls' link, sorting of results by vote count » Add options to hide 'older polls' link, sorting of results by vote count
eMPee584’s picture

eMPee584 CreditAttribution: eMPee584 commented
Title: Add options to hide 'older polls' link, sorting of results by vote count » Sorting of results by vote count, option to hide 'older polls' link

Be the first to review this patch and you might win a two-week trip to the carribean sea on one of our luxurious cruise liners! Or not, maybe.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs review » Needs work

The last submitted patch failed testing.

eMPee584’s picture

eMPee584 CreditAttribution: eMPee584 commented
Status: Needs work » Needs review
FileSize
poll-module-add-sorting-and-link-visibility-options.patch7.25 KB

New bigger better patch revision.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs review » Needs work

The last submitted patch failed testing.

lilou’s picture

lilou CreditAttribution: lilou commented
Status: Needs work » Needs review

Your patch fail since #332123: Remove t() from all schema descriptions commit.

lilou’s picture

lilou CreditAttribution: lilou commented
FileSize
issue-295958-7.patch7.88 KB

Reroll ;-)

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Needs work

pollslink and sortresult shouldn't be munged together like this. Also, this should come with test - and probably a screenshot for easier review of the functionality.

eMPee584’s picture

eMPee584 CreditAttribution: eMPee584 commented

Catch would you mind adding a tiny bit of in-detail information about what you mean by shouldn't be munged together, thanks.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

eMPee584, sorry, I meant we usually do $polls_link and $sort_result.

eMPee584’s picture

eMPee584 CreditAttribution: eMPee584 commented

ok that cleared, another thing: is there any other patch adding this or similar functionality to polls module i am not aware of? If not, i'll separate both features and submit them.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

I'm not aware of any. And yes, if the patch can be split into two smaller ones, that's a good idea.

eMPee584’s picture

eMPee584 CreditAttribution: eMPee584 commented

well ok.. but thinking of it, i am still not sure if the setting to show or hide the link to older polls should be a property of the poll node or a per block/ general setting...

Jooblay.net’s picture

Jooblay.net CreditAttribution: Jooblay.net commented
Issue summary: View changes

What is the status of this ticket:) Can we close this...