I did a general cleaning of page.tpl.php.
* Logic, even very simple, should be in template.php
* Use only one way of if-else, not three
* print $foo ? $foo : '' is silly: you print an empty string if the string you want to print is empty. This if does the same as print $foo.
* Made code apply to Drupals spacing rules.
* Simplified many string concatanations and if structures, by rewriting them into
or removing print '. $something .' structures. Sure, not the best-performing solution, but consistent, and very readable for developers (and dreamweaver).

Patch will follow.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Bèr Kessels’s picture

Status: Active » Needs review
FileSize
8.59 KB

PAtch attached