Use dependency injection in MigrationConfigurationTrait

https://api.drupal.org/api/drupal/core!lib!Drupal!Core!StringTranslation... is an example using setter injection.

$stringTranslation property.

setStringTranslation() method.

getStringTranslation() with a fallback to \Drupal.

Assigning to self for review

No longer applies, needs a reroll

According to the scope of this issue this patch should only modify MigrationConfigurationTrait and use dependency injection in that trait but this patch is modifying way more than this. Patch is using dependency injection in migrate_drupal and migrate_drupal_ui module which is a bigger change.

I'll suggest make dependency injection in migrate_drupal module in this issue and create another follow-up issue to use dependency injection in migrate_drupal_ui module. Rename this issue to Use dependency injection in migrate_drupal module

@maxocub, I finally read the comments #77 and #78 that suggested making this followup and like you I wasn't sure how it was to work here. However, after talking to you and heddn and reading the patch it makes sense. Thanks!

Aside from all the goodness of dependency injection I find that the Migrate Upgrade UI form classes are tidier and easier to read and that is most welcome. So, RTBC it is.

+++ b/core/modules/migrate_drupal_ui/src/Form/MigrateUpgradeFormBase.php
@@ -25,10 +28,19 @@
+  public function __construct(ConfigFactoryInterface $config_factory, MigrationPluginManagerInterface $migration_plugin_manager, StateInterface $state, PrivateTempStoreFactory $tempstore_private) {
+    $this->setConfigFactory($config_factory);
+    $this->setMigrationPluginManager($migration_plugin_manager);
+    $this->setState($state);

The setters don't seem necessary here - all the classes being modified use constructor injection, we're not actually using setter injection anywhere. Apart from that looks good.

Thanks, looks good.

Thanks @maxocub for clarifying in #9.

This fails on php 5.5?

The problem is that both FormBase and MigrationConfigurationTrait declare $configFactory, and MigrateUpgradeFormBase uses both classes, but overwriting properties with traits is not allowed.

Postpone until the 8.8.x branch is open? PHP 5 is going away and #2842431: [policy] Remove PHP 5.5, 5.6 support in Drupal 8.7 states "All currently supported PHP versions will be tested during the 8.7.x development phase prior to 8.7.0, since PHP 5.5 must be supported for Drupal 8.6 backports." - although this will never be backported it will also never pass the 8.7.x tests.

No longer postponed

Here's a reroll.

Looking good. Nice solid PHP practices at work here

Committed b6b1358 and pushed to 8.8.x. Thanks!