On every entity check, "checkTree" is getting the schema menu tree. This is causing a huge overhead (and timeouts) if there are several menus with thousands of nodes on each one (my situation: 4 menus with +1000 nodes).

IMHO, the menu tree must be cached in some way.

CommentFileSizeAuthor
#9 2965924-workbench_access-static-cache-9.patch1.71 KBagentrickard
#8 2965924-workbench_access-static-cache-8.patch1.5 KBagentrickard
#2 cache_scheme_menu_tree-2965924-1.patch1.1 KBrutiolma
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rutiolma created an issue. See original summary.

rutiolma’s picture

rutiolma
Location 🇵🇹
CreditAttribution: rutiolma commented
FileSize
cache_scheme_menu_tree-2965924-1.patch1.1 KB

Something like this will work

rutiolma’s picture

rutiolma
Location 🇵🇹
CreditAttribution: rutiolma commented
Status: Active » Needs review
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented
Category: Bug report » Task

Not a bug.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented

BTW: I've always assumed that tree caching happens at the core level, and I've never liked using Menu for access control because of this very overhead.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented
Status: Needs review » Needs work

You cannot put menu-specific handling code in the WorkbenchAccessManager. That is a base class that handles plugin implementations.

I agree with the need for caching, but this needs to be abstracted for use with all Plugin types.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented

This also needs means and tests for cache invalidation.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented
Status: Needs work » Needs review
FileSize
2965924-workbench_access-static-cache-8.patch1.5 KB

New patch. Running tests now.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented
FileSize
2965924-workbench_access-static-cache-9.patch1.71 KB

New patch.

  • agentrickard committed 0629db9 on 8.x-1.x 
    Issue #2965924 by agentrickard, rutiolma: Menu tree is generated for...
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.