CommentFileSizeAuthor
#7 short array.png437.25 KBriddhi.addweb
#5 coding-standards-2971620.patch7.93 KBmmv93
#2 2971620_1.patch6.85 KBchanderbhushan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chanderbhushan created an issue. See original summary.

chanderbhushan’s picture

chanderbhushan CreditAttribution: chanderbhushan as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Active » Needs review
FileSize
2971620_1.patch6.85 KB

added patch

msankhala’s picture

msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commented
Status: Needs review » Needs work

Why not fix all the coding standard, not just short array syntax.
Here is a list of all the coding standard issue with this module https://pareview.sh/pareview/https-git.drupal.org-project-back_to_top.gi...

mmv93’s picture

mmv93 CreditAttribution: mmv93 at EPAM Systems commented

Changed array() to []. Also changed some typos.

mmv93’s picture

mmv93 CreditAttribution: mmv93 at EPAM Systems commented
FileSize
coding-standards-2971620.patch7.93 KB

Changed array() to []. Also changed some typos.

mmv93’s picture

mmv93 CreditAttribution: mmv93 at EPAM Systems commented
Status: Needs work » Needs review
riddhi.addweb’s picture

riddhi.addweb CreditAttribution: riddhi.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Needs review » Reviewed & tested by the community
FileSize
short array.png437.25 KB

@mmv93, Thanks for Contributing the patch, your patch resolves all the short array mentioned errors shown in Pareview report. your patch is working fine for me as per the requirements.

Thanks!.

msankhala’s picture

msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commented

It's @mmv93's patch not mine.

riddhi.addweb’s picture

riddhi.addweb CreditAttribution: riddhi.addweb at AddWeb Solution Pvt. Ltd. commented

@msankhala, Sorry!. I made mistake I'm updating my comment. Thanks! for your concern

acke’s picture

acke CreditAttribution: acke at Happiness commented
Status: Reviewed & tested by the community » Fixed

Some of this was fixed in https://www.drupal.org/node/3080772 but the BackToTopSettingsForm.php wasn't. I add this, thanks for helping.

  • acke committed f8de021 on 8.x-1.x authored by mmv93 
    Issue #2971620 by chanderbhushan, mmv93, riddhi.addweb: replace array()...
acke’s picture

acke CreditAttribution: acke at Happiness commented

Ok, my mistake here, I change back to right format.

  • acke committed dfdd97e on 8.x-1.x 
    Issue #2971620 by chanderbhushan, mmv93, riddhi.addweb, acke: replace...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.